Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info popup about Argentinian Peso market prices. #6840

Merged
merged 1 commit into from Sep 6, 2023
Merged

Add info popup about Argentinian Peso market prices. #6840

merged 1 commit into from Sep 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2023

@HenrikJannsen requested we display some info about the new ARS blue rate to users.


This will show at application startup and can be dismissed with the "Don't show again" option.

bluedollar


FYI 50% of pricenodes are currently providing blue market rates for ARS, the remaining 50% have not yet updated.

@alvasw
Copy link
Contributor

alvasw commented Sep 6, 2023

This won't affect the majority of our users. We can show the dialog at start-up to users with an ARS payment account and additionally to everyone when they navigate to the ARS currency. What do you think?

@ghost
Copy link
Author

ghost commented Sep 6, 2023

I would think showing the news popup at startup helps attract users to the ARS market! (Personally I don't think its an inconvenience, especially since there's a Don't show again option).

show the dialog at start-up to users with an ARS payment account

Likely very few users would see it; bear in mind there have only been 10 lifetime trades. Also weigh the challenge of testing all possible payment methods for ARS.

Happy enough to implement those changes if that's what the community wants. @rodvar @pazza83 your thoughts?

@alvasw
Copy link
Contributor

alvasw commented Sep 6, 2023

I agree with you!

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit f84ebc2 into bisq-network:master Sep 6, 2023
12 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Sep 6, 2023
@rodvar
Copy link

rodvar commented Sep 6, 2023

Awesome guys!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants