Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would be nice to try to go to main version tree of bitcoinj or make PR of our changes. TB Discuss
2 test were mark as ignored by me, can not judge if they are broken because of our branch chnages or because of a bug that may be solved already in main tree version of bitcoinj
I did add some code tricks to avoid manual changes to JDK, so it is a bit more easy to run and it's lower the barrier entry to submit code for newcomer (now git clone and run, no changes needed for JDK)
with this maven test are green locally and in travis