-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Cycle 18 #685
Comments
The 3200 USD for bisq-network/projects#25 seems a bit high to me. Consider also the lost effort which went into your implementation from various reviewers. For not merged code there is usually no compensation. As the concept was good and was used as base for the final implementation as well as your code base (though that got transformed to a huge extent) I agree that we should compensate your efforts for that project. Thought the amount seems too high to me. |
@freimair Could you please respond to this comment as I haven't reviewed the PR in discussion? Thanks! |
I disagree. Yes, coding style changed a lot, yes, the "version" information has its own protocol field now, and yes, stuff only applies to TradeStatistics now. But overall, the business logic did not change too much and I could have made these changes with very little efforts based on my ready-to-ship PR. However, the project was defined as is half a year ago (by a group of people) I was not aware of the new requirements. You pretty much took a finished solution and refactored it - can be seen clearly because your first PR bisq-network/bisq#4519 has been solely based on all my code. Also consider, that sq, aka the reviewer, and I had in-depth discussions on how stuff works and that it is a big and risky step. The reviewer therefore knew the concept of the PR already, and hence, did not have to invest too much time into thinking through a whole new PR. Please note that I did not ask for compensation for testing, because you took the liberty to delete all tests.
That kind-of changed with the rise of the projects concept. Projects have been introduced to reduce the risk of big changes not being compensated and thus, encourage more people to do bigger projects and thus, really improve Bisq. Unfortunately, since the project concept has been introduced, pretty much only I adopted the process for non-management projects and only 2 projects got closed (the KPIs and bisq-network/projects#25) so far.
For making Bisq work again? I disagree. (details: because slow inet, i.e. tor, speed means Bisq cannot be used and we only have around 450 active nodes at each time, loosing more would not benefit the project - keep in mind that we already might have lost lots of users because of these issues). And the project has been priced at a discount to begin with and I only ask for roughly half of it anyways. |
We both have the right to disagree. So will I. |
I understand that your vote will make my compensation request fail if I do not lower the amount for the project in question, so I will include that part in my next compensation request. Maybe you care about naming an amount you are comfortable with? |
Based on the changes mentioned in #685 (comment) as stand in team lead I approve this request for dev now. |
@wiz can I have your two cents here as well? |
@freimair I think 50% of the initial request amount for that project is justified. |
It's fine but I thought @Emzy was taking over the Bisq monitor since you resigned? Are you guys still coordinating that? |
b3d5225b03c0e1477934e08cf19bf4f30a03d495eb5d6e06ecec7fe67c8120bc |
@freimair Can you please provide @Emzy the necessary information/data for the monitor setup (grafana config,...). Please check in all the data required to get a running monitor into a repo (can you yours) so its easier to share and transparent. I consider that as part of the monitor project the DAO has paid for and expect that the handover works without much hassle. Thanks in advance. |
@freimair I will support your open request once that handover is completed with the amount requested here + 50% of the "initial data request" amount you inititally requested. |
Based on the unresponsiveness on the missing handover of the items required to run the monitor I have to withdraw my approval for this compensation request this cycle. |
Closed as rejected. |
@freimair As stated above please provide all data and information to @Emzy so that he can start to setup the monitor and we can do the handover. The DAO has invested about 50 000 USD in the monitor project and we need to ensure that this investment does not vanish just because you left the project. To re-do all the work to setup Grafana would be too much of an effort to invest again into the project with quite limited value (it never fulfilled the purpose to be an alert system). If you don't provide the needed information to reduce the needed effort for the handover I consider that investment as a huge loss for Bisq. Holding back work you got paid for is not acceptable. My support for your outstanding requests is directly depending on that outstanding delivery. Also be assured I have not been the only one who rejected your request. |
This is still a problem ... the website links to a broken monitor .... |
Commented out the monitor for now given it's been broken for a year or so, which could be wrongly interpreted as "Bisq itself has problems". Files affected: _data/*.yml See: - bisq-network/bisq#5297 (comment) - bisq-network/bisq#5340 - bisq-network/compensation#685 (comment)
Commented out the "monitor" site link for now, given it's been broken for a year or so, which could be wrongly interpreted as "Bisq itself has problems". Files affected: _layouts/page_stats.html See (non-exhaustive list of related discussions): - bisq-network/bisq#5297 (comment) - bisq-network/bisq#5340 - bisq-network/compensation#685 (comment)
Summary
3603
Contributions delivered
Contributions in progress
The text was updated successfully, but these errors were encountered: