Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Use the map frame as default #15

Merged
merged 1 commit into from
May 21, 2021
Merged

Use the map frame as default #15

merged 1 commit into from
May 21, 2021

Conversation

Flova
Copy link
Member

@Flova Flova commented May 21, 2021

Proposed changes

  • Changes param

Some tests in webots resulted in much better results when filtering in the map frame.

Necessary checks

  • Run catkin build
  • Test on your machine
  • Put the PR on our Project board

@NFiedler NFiedler mentioned this pull request May 21, 2021
Closed
NFiedler
NFiedler approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@NFiedler NFiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I think we need to consider #16 when merging this.

@Flova
Copy link
Member Author

Flova commented May 21, 2021

I think the said issue is also important, but we have the open issue and will be remined. This pr is just for now.

@Flova Flova merged commit 20eca56 into master May 21, 2021
@Flova Flova deleted the param/use_map_frame branch May 21, 2021 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NFiedler NFiedler NFiedler approved these changes

@timonegk timonegk Awaiting requested review from timonegk

@jaagut jaagut Awaiting requested review from jaagut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flova @NFiedler