Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process should copy extra static files #39

Closed
imaustink opened this issue Jul 6, 2017 · 3 comments
Closed

Build process should copy extra static files #39

imaustink opened this issue Jul 6, 2017 · 3 comments
Assignees

Comments

@imaustink
Copy link
Contributor

imaustink commented Jul 6, 2017

In addition to copying the bundles, we should also copy static files from the /extra folder of the template plugin. This would be useful for things like image and Worker files.

The change should probably happen here: https://github.com/bit-docs/bit-docs-generate-html/blob/master/site/default/static/build.js#L41

Justin brought this up here: https://bitovi.slack.com/archives/C09R50SAE/p1499289208210257

@imaustink imaustink changed the title Build process should copy extra static Build process should copy extra static files Jul 6, 2017
@imaustink imaustink self-assigned this Jul 6, 2017
@chasenlehara
Copy link
Contributor

@justinbmeyer There’s already code for copying static files into the build:

if(options["static"]){
return fss.copyFrom(options["static"], buildFolder);
}

Would it be best to just use that instead of modifying the code mentioned in this issue’s description?

@justinbmeyer
Copy link
Member

@chasenlehara yeah, probably. Thought we should make it so static can be an array of sources. Lets talk about this at some point.

@chasenlehara
Copy link
Contributor

#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants