Add staticDist option #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
requested changes
Jul 10, 2017
site/default/static/build.js
Outdated
|
|
||
| var promise = Q.all([ | ||
| fsx.copy(path.join(folders.build, "dist"), path.join(folders.dist)) | ||
| ].concat(staticDistPromises)); |
There was a problem hiding this comment.
This code is duplicated here and in the options.devBuild statement branch; could this be refactored to not be repeated in both places?
build/build_test.js
Outdated
| "can-component": "3.0.0-pre.9" | ||
| }, | ||
| staticDist: [ | ||
| 'test-static-dist' |
There was a problem hiding this comment.
Should this be an array of files, folders, or either?
chasenlehara
approved these changes
Jul 11, 2017
This was referenced Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html.staticDistoption for copying static assets from a template