Refactor: Replace Config.user() by getpass.getuser() #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
commented
Apr 21, 2024
| if cfg.isConfigured(): | ||
| return cfg | ||
| except: | ||
|
|
||
| except Exception as exc: |
There was a problem hiding this comment.
Catching all exception but doing nothing about it (pass). Can not imagine how much bugs this may hide or trigger.
buhtz
commented
Apr 21, 2024
| @@ -155,7 +155,9 @@ def test_local_snapshot_is_successful(self): | |||
|
|
|||
| line_contains_to_exclude = [ | |||
| "Gtk-WARNING", | |||
| "qt.qpa.plugin: Could not find the Qt platform plugin" | |||
| "qt.qpa.plugin: Could not find the Qt platform plugin", | |||
| 'qt.dbus.integration: Could not connect "org.freedesktop.IBus" ' | |||
There was a problem hiding this comment.
This error message appeared in the output of my machine.
IBus is related to the setup of input method (switching between German and Japanese keyboard).
buhtz
added
the
PR: Merge after creative-break
buhtz
added a commit
to cgrinham/backintime
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1694