Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop @expectedException in favour of self::expectException #108

Closed
shochdoerfer opened this issue Sep 6, 2017 · 2 comments
Closed

Drop @expectedException in favour of self::expectException #108

shochdoerfer opened this issue Sep 6, 2017 · 2 comments
Milestone
0.10.0

Comments

@shochdoerfer
Copy link
Member

There are a bunch of @expectedException* annotations left in the unit tests which should be replaced by the corresponding self::expectException*() method calls due to being "a new best practice" as well as for consistency reasons.
@shochdoerfer shochdoerfer added this to the 0.10.0 milestone Sep 6, 2017
@shochdoerfer
Copy link
Member Author

@SenseException mind helping with this?

@SenseException
Copy link
Contributor

I can do that.

@SenseException SenseException mentioned this issue Sep 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@shochdoerfer @SenseException