Updated resource ACL #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After installation exception being thrown when trying to access store configuration:
```ssh
Invalid XML in file {...}/bitexpert/magento2-force-customer-login/etc/adminhtml/system.xml:
Element 'resource': [facet 'pattern'] The value 'bitExpert::ForceCustomerLogin' is not accepted by the pattern '([A-Z]+[a-zA-Z0-9]{1,}){1,}_[A-Z]+[A-Z0-9a-z]{1,}::[A-Za-z_0-9]{1,}'. Line: 11
Element 'resource': 'bitExpert::ForceCustomerLogin' is not a valid value of the atomic type 'typeAclResourceId'. Line: 11
```
Appears to be due to incorrect value for resource
|
Hi @chedaroo, Thank you for your contribution! Your changes have been merged. |
|
@websharp thanks for merging, could you release this update as 2.0.0-RC3 please? If you have a roadmap for 2.0.0 and beyond I may be able to help out. |
|
Hi @adamj88 , 2.0.0-RC3 has been released today, happy to get feedback if everything works now as expected. For the moment there is no clear roadmap, but I would gladly discuss feature requests (by issue or PR) if you think the module would benefit from that. If you want to discuss in private, you could address this to @shochdoerfer or myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installation exception being thrown when trying to access store configuration:
Appears to be due to incorrect value for resource