Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed wrong indent of return FAILURE statement in failer.gd #27

Merged
merged 2 commits into from
Aug 23, 2022
Merged

fixed wrong indent of return FAILURE statement in failer.gd #27

merged 2 commits into from
Aug 23, 2022

Conversation

Foxomat
Copy link
Contributor

@Foxomat Foxomat commented Aug 23, 2022

Description & Addressed issues

see #26

Checklist

  • changes performed compatible with Godot 3.x
  • changes performed compatible with Godot 4.x (raised in a separate PR against the 2.x branch in case the change is not compatible with Godot 3.x like specific syntax)
  • Unit tests (Godot 4 only after Unit tests with gdUnit (Godot 4.0 only) #2 is done)

Foxomat and others added 2 commits August 23, 2022 08:24
@Foxomat
fixed wrong indent of return FAILURE statement in failer.gd
8d0f8f3
@Foxomat
fixed indent in example
6df4f0e 
fixed indent of `actor.visible = true` statement in `MakeVisibleAction.gd` example
@bitbrain bitbrain added the 🍒 cherrypick:godot3 The resulting squash commit can be cherry-picked onto the 4.0 branch label Aug 23, 2022
bitbrain
bitbrain approved these changes Aug 23, 2022
View reviewed changes
Copy link
Owner

@bitbrain bitbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@bitbrain bitbrain merged commit 166bd6b into bitbrain:godot-3.x Aug 23, 2022
bitbrain pushed a commit that referenced this pull request Aug 23, 2022
@Foxomat @bitbrain
fixed wrong indent of return FAILURE statement in failer.gd (#27)
12ec281 
* fixed wrong indent of `return FAILURE` statement in `failer.gd`

* fixed indent in example

fixed indent of `actor.visible = true` statement in `MakeVisibleAction.gd` example
@bitbrain bitbrain removed the 🍒 cherrypick:godot3 The resulting squash commit can be cherry-picked onto the 4.0 branch label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitbrain bitbrain bitbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Foxomat @bitbrain