Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LightingManager API 🔦 #183

Closed
bitbrain opened this issue Mar 21, 2019 · 0 comments
Closed

Improve LightingManager API 🔦 #183

bitbrain opened this issue Mar 21, 2019 · 0 comments

Comments

@bitbrain
Copy link
Owner

bitbrain commented Mar 21, 2019

The current implementation lacks on functionality such as removing lights again. Also the API is quite hard to use right now.

Adding and removing lights

It is currently quite annoying to specify a light id. Why is this even required? Generate one! Also return the light itself:

PointLight light = lightingManager.createPointLight(pos, radius, color);

Make it simple to remove lights again:

lightingManager.removeLight(light);

Attaching lights to objects

Right now, it is quite difficult to attach lights. Change that:

lightingManager.attach(object, light);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant