ValueInput "EMPTY" state #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2023
jarolrod
force-pushed
the
valinput-empty-state
branch
from
e7a6997
to
26aa64c
Compare
It has just been merged. Rebase? |
jarolrod
force-pushed
the
valinput-empty-state
branch
from
26aa64c
to
85d4cf0
Compare
jarolrod
force-pushed
the
valinput-empty-state
branch
from
85d4cf0
to
1a7c3ce
Compare
|
Updated from 85d4cf0 to 1a7c3ce, compare Changes:
|
The EMPTY state indicates that this setting hasn't been touched. Clicking on the Setting that contains the ValueInput is enough to put it in the FILLED state.
jarolrod
force-pushed
the
valinput-empty-state
branch
from
1a7c3ce
to
003f174
Compare
|
ACK 003f174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
"EMPTY"state toValueInput, as specified in the design file.This state is only added to
ValueInputbecause theSettingcontrol should not care about this. All other states continue to function as normal*.Light
Dark
*the Setting control loses the active state when the mouse moves away from it, will be addressed in a follow-up.