Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember user's peer sort preference #371

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Nov 10, 2023

This sets the sort preference for the peers table in qsettings so that
it can be remembered. Also addresses an issue where the id toggle button is always checked when you go back to the table even though the table is not sorted by id.

Build Artifacts

@jarolrod
Copy link
Member Author

Updated from 979a984 to afcb1f7

changes: made qsettings setting name for the last sort in the peer list less generic

Copy link
Contributor

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK afcb1f7

@hebasto
Copy link
Member

hebasto commented Nov 23, 2023

Please rebase.

Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK afcb1f7

This sets the sort preference for the peers table in qsettings so that
it can be remembered. Also addresses an issue where the `id`
toggle button is always checked when you go back to the table even
though the table is not sorted by `id`.
@jarolrod
Copy link
Member Author

Updated from afcb1f7 to 9cd558e

Changes: rebased over main

Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 9cd558e

Verified that the issue where id toggle button is always checked gets fixed with this PR.

@hebasto hebasto merged commit bc6f872 into bitcoin-core:main Nov 27, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants