Draw "eye" sign at the beginning of watch-only addresses #365
Conversation
hebasto
added
Bug
There was a problem hiding this comment.
ACK 18ff8eb
Tested on macOS 11.3 Qt 5.15.2, Arch Linux Qt 5.15.2 and cross-compile to Windows 10.
Notes on Commits:
This fixes issue #22246, see: bitcoin/bitcoin#22246 (comment)
The below screenshots show the behavior between master and this PR when presented with more than one address in a transaction on the overview page across the major platforms.
Note: The before and after screenshots are taken with gui settings wiped. If a user upgrades from v0.21.1 to v22, the window will open up as wide as it was on v0.21.1. They must then resize it to their preference, this change no longer prevents you from making the window smaller (as noted in #22246)
macOS 11.3
| Master | PR |
|---|---|
 |
 |
Arch Linux
| Master | PR |
|---|---|
 |
 |
Windows 10
| Master | PR |
|---|---|
 |
 |
This is a nice improvement UX wise for watch only wallets. The watch symbol is placed on the left hand, could not force any weird behavior from this change.
Below I attach screenshots of this PR applied on the major platforms for the purposes of documentation and clarity
macOS 11.3
| Master | PR |
|---|---|
 |
 |
Arch Linux
| Master | PR |
|---|---|
 |
 |
Windows 10
| Master | PR |
|---|---|
 |
 |
src/qt/overviewpage.cpp
Outdated
| @@ -107,9 +106,9 @@ class TxViewDelegate : public QAbstractItemDelegate | |||
|
|
|||
| painter->setPen(option.palette.color(QPalette::Text)); | |||
| QRect date_bounding_rect; | |||
| painter->drawText(amountRect, Qt::AlignLeft | Qt::AlignVCenter, GUIUtil::dateTimeStr(date), &date_bounding_rect); | |||
| painter->drawText(amountRect, Qt::AlignLeft | Qt::AlignVCenter, GUIUtil::dateTimeStr(date) + QLatin1String(" "), &date_bounding_rect); | |||
There was a problem hiding this comment.
Is this assuming spaces have a certain width?
There was a problem hiding this comment.
Do you prefer non-breaking space?
There was a problem hiding this comment.
Offset the bounding rect?
Spaces are never a well-defined width... except zero-width :)
There was a problem hiding this comment.
Offset in fixed number of pixels? Is it a good approach with potentially scalable fonts?
There was a problem hiding this comment.
Measure the icon width.
Scalable fonts is exactly why spaces won't work reliably. ;)
There was a problem hiding this comment.
Is this assuming spaces have a certain width?
Thanks! Updated.
…-only addresses cd46c11 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov) 9ea1da6 qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov) Pull request description: This PR guaranties that the "eye" sign won't be hidden for very long addresses/labels. No longer need to extend `TransactionOverviewWidget` widget width to make "eye" signs shown:  Fixes bitcoin-core/gui#373 ACKs for top commit: jarolrod: ACK cd46c11 Tree-SHA512: 0602b5bb65d53c5b18e86260750006bba03adbae181917b5a2b7f89b17290bd1f57b4f80adaba32f42cc6fb468598a888b12c0b6b09005d2f2c07bd4d1ad334a
Github-Pull: bitcoin-core/gui#365 Rebased-From: 9ea1da6
Github-Pull: bitcoin-core/gui#365 Rebased-From: cd46c11
|
Backported in bitcoin/bitcoin#22427. |
e3f1da4 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov) 6ca54ce qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov) f220368 qt: Do not use QClipboard::Selection on Windows and macOS. (Hennadii Stepanov) Pull request description: Backports bitcoin-core/gui#277, bitcoin-core/gui#365. ACKs for top commit: fanquake: ACK e3f1da4 jarolrod: ACK e3f1da4 Tree-SHA512: 43cc2ac48f4e5014bfdbe86cc904bb36d2be9fcd257f0fc0800c384bd727bb98466723e450a8909b06708784ad91184be599c49cf60de2e4377202774cb878f6
e3f1da4bf3db120cc691a844d612fbc522f11fb9 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov) 6ca54ce2ae0808513172c4945e38165e766e1381 qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov) f220368220abb11040fa944a853cda3d4f1fe84d qt: Do not use QClipboard::Selection on Windows and macOS. (Hennadii Stepanov) Pull request description: Backports bitcoin-core/gui#277, bitcoin-core/gui#365. ACKs for top commit: fanquake: ACK e3f1da4bf3db120cc691a844d612fbc522f11fb9 jarolrod: ACK e3f1da4bf3db120cc691a844d612fbc522f11fb9 Tree-SHA512: 43cc2ac48f4e5014bfdbe86cc904bb36d2be9fcd257f0fc0800c384bd727bb98466723e450a8909b06708784ad91184be599c49cf60de2e4377202774cb878f6
This PR guaranties that the "eye" sign won't be hidden for very long addresses/labels.
No longer need to extend
TransactionOverviewWidgetwidget width to make "eye" signs shown:Fixes #373