Skip to content

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Nov 27, 2023

Transform the inputs after the format change in bitcoin/bitcoin@fa6b87b

Done by nuking the first 4 bytes with something like:

for f in ./script_flags/* ; do python -c "fn=\"$f\"; print(fn); open(fn+'.new', 'wb').write(open(fn,'rb').read()[4:]);" ; done

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bitcoin/bitcoin@6e9e4e6 also changed the input format fwiw

@maflcko
Copy link
Contributor Author

maflcko commented Nov 27, 2023

bitcoin/bitcoin@6e9e4e6 also changed the input format fwiw

Only for src/test/fuzz/rpc.cpp, no?

@dergoegge
Copy link
Member

I might be wrong but after bitcoin/bitcoin@6e9e4e6 script_flags always deserializes txs with witness, which was decided based on the the stream version before, right?

@maflcko
Copy link
Contributor Author

maflcko commented Nov 27, 2023

Ah, right. But I guess there is no trivial python one-liner to transform those.

@dergoegge
Copy link
Member

Ah, right. But I guess there is no trivial python one-liner to transform those.

Yea I was just making a note of it, not saying you need change anything here.

@maflcko
Copy link
Contributor Author

maflcko commented Nov 27, 2023

rfm?

@fanquake fanquake merged commit 620b991 into bitcoin-core:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants