Skip to content

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented May 21, 2024

C.f. last one: #175

mv fuzz_seed_corpus fuzz_inputs_moved
../bitcoin-core/test/fuzz/test_runner.py -l DEBUG --par $( nproc ) --m_dir ./fuzz_inputs_moved/  --m_dir ./results_from_working_farm --m_dir ../etc/... ./fuzz_seed_corpus
git restore -- ./fuzz_seed_corpus
git add ./fuzz_seed_corpus
git commit -m "Add fuzz inputs"

@murchandamus
Copy link
Contributor

I am never quite sure how I’m supposed to read those two coverage reports. 😅

If I read it right, the main branch has no coverage of sha256_avx2.cpp, sha256_sse4.cpp, and sha256_sse41.cpp, while the feature branch has full coverage of those three, but the main branch had full coverage of sha256_x86_shani.cpp and the feature branch has none.
Are these different architectures where only one or the other applies?

image

Otherwise looks like some nice NgU

@maflcko
Copy link
Contributor Author

maflcko commented May 21, 2024

I am never quite sure how I’m supposed to read those two coverage reports. 😅

Yeah, it is a bit unfortunate that they were produced on machines with different hardware. I guess I can try to normalize them in configure somehow.

@maflcko maflcko marked this pull request as draft May 21, 2024 16:21
@maflcko
Copy link
Contributor Author

maflcko commented May 21, 2024

Draft for now to look into the timeout.

@maflcko maflcko marked this pull request as ready for review May 24, 2024 07:26
@maflcko
Copy link
Contributor Author

maflcko commented May 24, 2024

@murchandamus
Copy link
Contributor

image

LGTM

@dergoegge
Copy link
Member

Gonna wait for bitcoin/bitcoin#30169

@murchandamus
Copy link
Contributor

Looks like it got merged

@maflcko
Copy link
Contributor Author

maflcko commented May 27, 2024

rfm?

@dergoegge dergoegge merged commit cad8fa8 into bitcoin-core:main May 27, 2024
@maflcko maflcko mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants