Skip to content

Conversation

agroce
Copy link
Contributor

@agroce agroce commented Jul 24, 2024

Result of running muttfuzz on this target a few days (see https://github.com/agroce/muttfuzz)

Merge performed using FUZZ=mocked_descriptor_parse src/test/fuzz/fuzz ../qa-assets/fuzz_seed_corpus/mocked_descriptor_parse new_mocked_descriptor_parse_corpus -set_cover_merge=1

MERGE-OUTER: successful in 1 attempt(s)
MERGE-OUTER: the control file has 266333613 bytes
MERGE-OUTER: consumed 134Mb (595Mb rss) to parse the control file
MERGE-OUTER: 117 new files with 660 new features added; 10 new coverage edges

@maflcko
Copy link
Contributor

maflcko commented Jul 25, 2024

lgtm: Minimal cov and ft increase:

https://cirrus-ci.com/task/6557624982831104?logs=ci#L6881:

mocked_descriptor_parse                  #2876	DONE   cov: 16902 ft: 98632 corp: 2191/3276Kb lim: 974476 exec/s: 3 rss: 657Mb

https://cirrus-ci.com/task/4855101825744896?logs=ci#L6891 (master):

mocked_descriptor_parse                  #2760	DONE   cov: 16901 ft: 97969 corp: 2102/3231Kb lim: 974476 exec/s: 2 rss: 663Mb

However, the fuzz target was recently changed in bitcoin/bitcoin@262260c, so it may have rediscovered fuzz inputs that previously achieved the same coverage in real code, but were invalidated by the recently added checks (I haven't checked that).

Looks good to merge in either case. Thanks!

@dergoegge dergoegge merged commit 87b05f9 into bitcoin-core:main Jul 25, 2024
4 checks passed
@dergoegge
Copy link
Member

Thank you Alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants