Skip to content

Conversation

murchandamus
Copy link
Contributor

@murchandamus murchandamus commented Aug 1, 2024

Adds new seeds per same methodology as in #186 and adds initial corpora for the following eleven fuzz targets:

  • clusterlin_add_dependency
  • clusterlin_ancestor_finder
  • clusterlin_chunking
  • clusterlin_cluster_serialization
  • clusterlin_depgraph_serialization
  • clusterlin_linearization_chunking
  • clusterlin_linearize
  • crypter
  • crypto_aeadchacha20poly1305
  • crypto_fschacha20poly1305
  • p2p_handshake

- crypter
- crypto_aeadchacha20poly1305
- crypto_fschacha20poly1305
@murchandamus
Copy link
Contributor Author

The number of lines added here seems off. Looking into what happened there.

@maflcko
Copy link
Contributor

maflcko commented Aug 1, 2024

Would be nice to add p2p_handshake as well. Either here or in a follow-up. (I'll do it later this month, when I submit my fuzz inputs, if no one beats me to it)

@murchandamus
Copy link
Contributor Author

I checked and my version of Bitcoin Core did not have that fuzz target, then realized that it just got merged yesterday. I can add it tomorrow to this PR after fuzzing it the next day or so.

@murchandamus murchandamus marked this pull request as draft August 1, 2024 16:47
@murchandamus
Copy link
Contributor Author

Still around 240,000 new seeds, so I guess I didn’t do it wrong the first time after all.

@murchandamus murchandamus marked this pull request as ready for review August 2, 2024 12:33
@dergoegge
Copy link
Member

Still around 240,000 new seeds, so I guess I didn’t do it wrong the first time after all.

$ git diff --diff-filter=A --name-only origin/main..c98fc19a89d6c54a4b92d8e51a9b49d536d02ed2 | wc -l
1496
$ git diff --diff-filter=A --name-only origin/main..murch/2024-08-add-seeds | wc -l
19535

Only 1.5k new seeds for the new harnesses and about 20k new seeds in total, which seems fine.

I think the ~240k number refers to added lines (not sure how much sense that makes w.r.t fuzz inputs).

@murchandamus
Copy link
Contributor Author

I see. I was assuming that any fuzz seed would be a single line

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting on CI

@murchandamus murchandamus changed the title Add ten initial corpora and new seeds Add eleven initial corpora and new seeds Aug 2, 2024
@maflcko
Copy link
Contributor

maflcko commented Aug 2, 2024

You'll have to revert the changes to that folder, or otherwise exclude the inputs.

See bitcoin/bitcoin#30514

Maybe a temporary revert for just that folder, so that they can be added back afterwards easily?

@murchandamus
Copy link
Contributor Author

I have reverted the addition of seeds for the utxo_snapshot target

@maflcko
Copy link
Contributor

maflcko commented Aug 2, 2024

I've added a reminder to bitcoin/bitcoin#30514 (comment)

@dergoegge dergoegge merged commit b68b278 into bitcoin-core:main Aug 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants