-
Notifications
You must be signed in to change notification settings - Fork 73
Add eleven initial corpora and new seeds #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- crypter - crypto_aeadchacha20poly1305 - crypto_fschacha20poly1305
The number of lines added here seems off. Looking into what happened there. |
Would be nice to add |
I checked and my version of Bitcoin Core did not have that fuzz target, then realized that it just got merged yesterday. I can add it tomorrow to this PR after fuzzing it the next day or so. |
bb1b90d
to
5fe446c
Compare
5fe446c
to
de62ef0
Compare
Still around 240,000 new seeds, so I guess I didn’t do it wrong the first time after all. |
Only 1.5k new seeds for the new harnesses and about 20k new seeds in total, which seems fine. I think the ~240k number refers to added lines (not sure how much sense that makes w.r.t fuzz inputs). |
I see. I was assuming that any fuzz seed would be a single line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, waiting on CI
You'll have to revert the changes to that folder, or otherwise exclude the inputs. Maybe a temporary revert for just that folder, so that they can be added back afterwards easily? |
I have reverted the addition of seeds for the utxo_snapshot target |
I've added a reminder to bitcoin/bitcoin#30514 (comment) |
Adds new seeds per same methodology as in #186 and adds initial corpora for the following eleven fuzz targets: