Skip to content

Conversation

murchandamus
Copy link
Contributor

Repeat of #217, but merged without using sanitizers.

@maflcko
Copy link
Contributor

maflcko commented Feb 6, 2025

coverage previous pull:https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/1172bc4157eefe80/7ca0eff221557a8b/fuzz.coverage/index.html
coverage this pull: https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/1172bc4157eefe80/107f00230b03630a/fuzz.coverage/index.html

Size previous pull: 6.0GB https://cirrus-ci.com/task/6267654383599616?logs=fuzz_inputs_total_size#L1
Size this pull: 5.1GB https://cirrus-ci.com/task/6300484341858304?logs=fuzz_inputs_total_size#L1

So it looks like this is overall better, because:

  • The coverage is the same (or slightly higher)
  • The size is smaller

Obviously, there could be a risk that is hard to measure that some sanitizer-triggering inputs are "missed", but this risk should be minimal and acceptable, because:

@maflcko
Copy link
Contributor

maflcko commented Feb 6, 2025

So, lgtm. I'll merge on Friday.

@murchandamus
Copy link
Contributor Author

Okay sounds good

@maflcko maflcko merged commit 733f70b into bitcoin-core:main Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants