fixup: make ValidationState abstract

bitcoin · Oct 29, 2019 · 2fc16d7 · 2fc16d7
1 parent ea83274
commit 2fc16d7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/Makefile.am b/src/Makefile.am
@@ -418,6 +418,7 @@ libbitcoin_consensus_a_SOURCES = \
   consensus/merkle.h \
   consensus/params.h \
   consensus/tx_check.cpp \
+  consensus/validation.cpp \
   consensus/validation.h \
   hash.cpp \
   hash.h \

diff --git a/src/consensus/validation.cpp b/src/consensus/validation.cpp
@@ -0,0 +1,7 @@
+// Copyright (c) 2019 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#include <consensus/validation.h>
+
+ValidationState::~ValidationState() {}
diff --git a/src/consensus/validation.h b/src/consensus/validation.h
@@ -92,8 +92,8 @@ class ValidationState {
         if (m_mode != MODE_ERROR) m_mode = MODE_INVALID;
     }
 public:
-    // We use ValidationState polymorphically. Have a virtual destructor
-    virtual ~ValidationState() {}
+    // ValidationState is abstract. Have a pure virtual destructor.
+    virtual ~ValidationState() = 0;
 
     ValidationState() : m_mode(MODE_VALID) {}
     bool Error(const std::string& reject_reason)