Skip to content

Commit

Permalink
add rescan bool to importprivkey to control whether to do a rescan af…
Browse files Browse the repository at this point in the history
…ter import
  • Loading branch information
mcassano committed Dec 7, 2012
1 parent d79775a commit 44051af
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions src/rpcdump.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,21 @@ class CTxDump

Value importprivkey(const Array& params, bool fHelp)
{
if (fHelp || params.size() < 1 || params.size() > 2)
if (fHelp || params.size() < 1 || params.size() > 3)
throw runtime_error(
"importprivkey <bitcoinprivkey> [label]\n"
"importprivkey <bitcoinprivkey> [label] [rescan=true]\n"

This comment has been minimized.

Copy link
@rebroad

rebroad Apr 1, 2013

Contributor

I would prefer to see this default to false.

This comment has been minimized.

Copy link
@rebroad

rebroad Jul 18, 2014

Contributor

This doesn't actually work...

This comment has been minimized.

Copy link
@sipa

sipa Jul 18, 2014

Member

Changing the default to false would 1) break backward compatibility 2) be unsafe

This comment has been minimized.

Copy link
@mcassano

mcassano via email Jul 18, 2014

Author Contributor
"Adds a private key (as returned by dumpprivkey) to your wallet.");

string strSecret = params[0].get_str();
string strLabel = "";
if (params.size() > 1)
strLabel = params[1].get_str();

// Whether to perform rescan after import
bool fRescan = true;
if (params.size() > 2)
fRescan = params[2].get_bool();

CBitcoinSecret vchSecret;
bool fGood = vchSecret.SetString(strSecret);

Expand All @@ -61,9 +67,11 @@ Value importprivkey(const Array& params, bool fHelp)

if (!pwalletMain->AddKey(key))
throw JSONRPCError(RPC_WALLET_ERROR, "Error adding key to wallet");

pwalletMain->ScanForWalletTransactions(pindexGenesisBlock, true);
pwalletMain->ReacceptWalletTransactions();

if (fRescan) {
pwalletMain->ScanForWalletTransactions(pindexGenesisBlock, true);
pwalletMain->ReacceptWalletTransactions();
}
}

return Value::null;
Expand Down

0 comments on commit 44051af

Please sign in to comment.