Skip to content

Commit

Permalink
Require a steady clock for bench with at least micro precision
Browse files Browse the repository at this point in the history
  • Loading branch information
TheBlueMatt committed Nov 9, 2017
1 parent 9e9e31a commit 620bae3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 3 additions & 0 deletions src/bench/bench.cpp
Expand Up @@ -23,6 +23,9 @@ void
benchmark::BenchRunner::RunAll(benchmark::duration elapsedTimeForOne)
{
perf_init();
if (std::ratio_less_equal<benchmark::clock::period, std::micro>::value) {
std::cerr << "WARNING: Clock precision is worse than microsecond - benchmarks may be less accurate!\n";
}
std::cout << "#Benchmark" << "," << "count" << "," << "min(ns)" << "," << "max(ns)" << "," << "average(ns)" << ","
<< "min_cycles" << "," << "max_cycles" << "," << "average_cycles" << "\n";

Expand Down
6 changes: 2 additions & 4 deletions src/bench/bench.h
Expand Up @@ -37,13 +37,11 @@ BENCHMARK(CODE_TO_TIME);
*/

namespace benchmark {
// On many systems, the high_resolution_clock offers no better resolution than the steady_clock.
// If that's the case, prefer the steady_clock.
// In case high_resolution_clock is steady, prefer that, otherwise use steady_clock.
struct best_clock {
using hi_res_clock = std::chrono::high_resolution_clock;
using steady_clock = std::chrono::steady_clock;
static constexpr bool steady_is_high_res = std::ratio_less_equal<steady_clock::period, hi_res_clock::period>::value;
using type = std::conditional<steady_is_high_res, steady_clock, hi_res_clock>::type;
using type = std::conditional<hi_res_clock::is_steady, hi_res_clock, steady_clock>::type;
};
using clock = best_clock::type;
using time_point = clock::time_point;
Expand Down

0 comments on commit 620bae3

Please sign in to comment.