Skip to content

Commit

Permalink
doc: remove obsolete okSafeMode RPC guideline from developer notes
Browse files Browse the repository at this point in the history
Since the flag has been removed from the RPC command table in commit
ec6902d (PR #11179), this guideline
is not relevant anymore and can be removed.
  • Loading branch information
theStack committed Jun 10, 2021
1 parent 46424e9 commit 6780a09
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions doc/developer-notes.md
Expand Up @@ -1160,13 +1160,6 @@ A few guidelines for introducing and reviewing new RPC interfaces:
- *Rationale*: If not, the call can not be used with name-based arguments.
- Set okSafeMode in the RPC command table to a sensible value: safe mode is when the
blockchain is regarded to be in a confused state, and the client deems it unsafe to
do anything irreversible such as send. Anything that just queries should be permitted.
- *Rationale*: Troubleshooting a node in safe mode is difficult if half the
RPCs don't work.

- Add every non-string RPC argument `(method, idx, name)` to the table `vRPCConvertParams` in `rpc/client.cpp`.
- *Rationale*: `bitcoin-cli` and the GUI debug console use this table to determine how to
Expand Down

0 comments on commit 6780a09

Please sign in to comment.