Skip to content

Commit

Permalink
Merge #27507: lint: stop ignoring LIEF imports
Browse files Browse the repository at this point in the history
015cc5e lint: stop ignoring LIEF imports (fanquake)

Pull request description:

  Type stubs are now available as of 0.13.0.
  See lief-project/LIEF#650.

ACKs for top commit:
  TheCharlatan:
    ACK 015cc5e

Tree-SHA512: ebb754f293c2a61a0ef64c3552f7c700ceb3054b50fd3f1573e4a9e87773ddeba47bd9875f6ab055043012dbc20aeb71e4d76cd3da535c76651dfb1fbfc66e89
  • Loading branch information
fanquake committed May 29, 2023
2 parents fb4f047 + 015cc5e commit 6cf47a8
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions ci/lint/04_install.sh
Expand Up @@ -35,6 +35,7 @@ fi

${CI_RETRY_EXE} pip3 install codespell==2.2.1
${CI_RETRY_EXE} pip3 install flake8==5.0.4
${CI_RETRY_EXE} pip3 install lief==0.13.1
${CI_RETRY_EXE} pip3 install mypy==0.971
${CI_RETRY_EXE} pip3 install pyzmq==24.0.1
${CI_RETRY_EXE} pip3 install vulture==2.6
Expand Down
2 changes: 1 addition & 1 deletion contrib/devtools/security-check.py
Expand Up @@ -10,7 +10,7 @@
import sys
from typing import List

import lief #type:ignore
import lief

def check_ELF_RELRO(binary) -> bool:
'''
Expand Down
2 changes: 1 addition & 1 deletion contrib/devtools/symbol-check.py
Expand Up @@ -13,7 +13,7 @@
import sys
from typing import List, Dict

import lief #type:ignore
import lief

# Debian 10 (Buster) EOL: 2024. https://wiki.debian.org/LTS
#
Expand Down
2 changes: 1 addition & 1 deletion contrib/devtools/test-security-check.py
Expand Up @@ -5,7 +5,7 @@
'''
Test script for security-check.py
'''
import lief #type:ignore
import lief
import os
import subprocess
from typing import List
Expand Down
1 change: 1 addition & 0 deletions test/README.md
Expand Up @@ -331,6 +331,7 @@ Use the `-v` option for verbose output.
| Lint test | Dependency |
|-----------|:----------:|
| [`lint-python.py`](lint/lint-python.py) | [flake8](https://gitlab.com/pycqa/flake8)
| [`lint-python.py`](lint/lint-python.py) | [lief](https://github.com/lief-project/LIEF)
| [`lint-python.py`](lint/lint-python.py) | [mypy](https://github.com/python/mypy)
| [`lint-python.py`](lint/lint-python.py) | [pyzmq](https://github.com/zeromq/pyzmq)
| [`lint-python-dead-code.py`](lint/lint-python-dead-code.py) | [vulture](https://github.com/jendrikseipp/vulture)
Expand Down
2 changes: 1 addition & 1 deletion test/lint/lint-python.py
Expand Up @@ -13,7 +13,7 @@
import subprocess
import sys

DEPS = ['flake8', 'mypy', 'pyzmq']
DEPS = ['flake8', 'lief', 'mypy', 'pyzmq']
MYPY_CACHE_DIR = f"{os.getenv('BASE_ROOT_DIR', '')}/test/.mypy_cache"

# All .py files, except those in src/ (to exclude subtrees there)
Expand Down

0 comments on commit 6cf47a8

Please sign in to comment.