Add comment to describe callers to ActivateBestChain

bitcoin · Jan 12, 2017 · 73666ad · 73666ad
1 parent 962f7f0
commit 73666ad
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -2388,6 +2388,11 @@ static void NotifyHeaderTip() {
  * that is already loaded (to avoid loading it again from disk).
  */
 bool ActivateBestChain(CValidationState &state, const CChainParams& chainparams, std::shared_ptr<const CBlock> pblock) {
+    // Note that while we're often called here from ProcessNewBlock, this is
+    // far from a guarantee. Things in the P2P/RPC will often end up calling
+    // us in the middle of ProcessNewBlock - do not assume pblock is set
+    // sanely for performance or correctness!
+
     CBlockIndex *pindexMostWork = NULL;
     CBlockIndex *pindexNewTip = NULL;
     do {