Skip to content

Commit

Permalink
qt: better looking trayicon
Browse files Browse the repository at this point in the history
Github-Pull: #4678
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
  • Loading branch information
ntrgn authored and laanwj committed Aug 12, 2014
1 parent 4c61ba4 commit 8bfdc9a
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 7 deletions.
1 change: 0 additions & 1 deletion doc/assets-attribution.md
Expand Up @@ -100,5 +100,4 @@ Jonas Schnelli
src/qt/res/icons/bitcoin.icns, src/qt/res/src/bitcoin.svg,
src/qt/res/src/bitcoin.ico, src/qt/res/src/bitcoin.png,
src/qt/res/src/bitcoin_testnet.png, docs/bitcoin_logo_doxygen.png,
src/qt/res/icons/toolbar.png, src/qt/res/icons/toolbar_testnet.png,
src/qt/res/images/splash.png, src/qt/res/images/splash_testnet.png
2 changes: 0 additions & 2 deletions src/Makefile.qt.include
Expand Up @@ -245,8 +245,6 @@ RES_ICONS = \
qt/res/icons/remove.png \
qt/res/icons/send.png \
qt/res/icons/synced.png \
qt/res/icons/toolbar.png \
qt/res/icons/toolbar_testnet.png \
qt/res/icons/transaction0.png \
qt/res/icons/transaction2.png \
qt/res/icons/transaction_conflicted.png \
Expand Down
2 changes: 0 additions & 2 deletions src/qt/bitcoin.qrc
Expand Up @@ -4,7 +4,6 @@
<file alias="address-book">res/icons/address-book.png</file>
<file alias="quit">res/icons/quit.png</file>
<file alias="send">res/icons/send.png</file>
<file alias="toolbar">res/icons/toolbar.png</file>
<file alias="connect_0">res/icons/connect0_16.png</file>
<file alias="connect_1">res/icons/connect1_16.png</file>
<file alias="connect_2">res/icons/connect2_16.png</file>
Expand All @@ -24,7 +23,6 @@
<file alias="editcopy">res/icons/editcopy.png</file>
<file alias="add">res/icons/add.png</file>
<file alias="bitcoin_testnet">res/icons/bitcoin_testnet.png</file>
<file alias="toolbar_testnet">res/icons/toolbar_testnet.png</file>
<file alias="edit">res/icons/edit.png</file>
<file alias="history">res/icons/history.png</file>
<file alias="overview">res/icons/overview.png</file>
Expand Down
4 changes: 2 additions & 2 deletions src/qt/bitcoingui.cpp
Expand Up @@ -479,12 +479,12 @@ void BitcoinGUI::createTrayIcon(bool fIsTestnet)
if (!fIsTestnet)
{
trayIcon->setToolTip(tr("Bitcoin Core client"));
trayIcon->setIcon(QIcon(":/icons/toolbar"));
trayIcon->setIcon(QIcon(":/icons/bitcoin"));
}
else
{
trayIcon->setToolTip(tr("Bitcoin Core client") + " " + tr("[testnet]"));
trayIcon->setIcon(QIcon(":/icons/toolbar_testnet"));
trayIcon->setIcon(QIcon(":/icons/bitcoin_testnet"));
}

trayIcon->show();
Expand Down
Binary file removed src/qt/res/icons/toolbar.png
Binary file not shown.
Binary file removed src/qt/res/icons/toolbar_testnet.png
Binary file not shown.

6 comments on commit 8bfdc9a

@Diapolo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laanwj We are once more loosing the transparency in the tray icon for Windows... I remember we had that already.

@laanwj
Copy link
Member

@laanwj laanwj commented on 8bfdc9a Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean, it's a square now?

@Diapolo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in the middle of the icon is just white, before it was transparent.

@laanwj
Copy link
Member

@laanwj laanwj commented on 8bfdc9a Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to look lime the image here: #4678

@Diapolo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That IS the case, just saying that there now is no transparency anymore. If this was wanted I'm fine with it.

@laanwj
Copy link
Member

@laanwj laanwj commented on 8bfdc9a Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well - it's indeed a change, but I don't think it's a negative one, it looks less "hollow" to me this way.

Please sign in to comment.