wallet: Add HasWallets

bitcoin · Apr 18, 2018 · ac0de44 · ac0de44
1 parent 432ea7d
commit ac0de44
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/src/rpc/misc.cpp b/src/rpc/misc.cpp
@@ -69,7 +69,7 @@ UniValue validateaddress(const JSONRPCRequest& request)
     {
 
 #ifdef ENABLE_WALLET
-        if (!GetWallets().empty() && IsDeprecatedRPCEnabled("validateaddress")) {
+        if (HasWallets() && IsDeprecatedRPCEnabled("validateaddress")) {
             ret.pushKVs(getaddressinfo(request));
         }
 #endif

diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -66,7 +66,7 @@ bool EnsureWalletIsAvailable(CWallet * const pwallet, bool avoidException)
 {
     if (pwallet) return true;
     if (avoidException) return false;
-    if (GetWallets().empty()) {
+    if (!HasWallets()) {
         // Note: It isn't currently possible to trigger this error because
         // wallet RPC methods aren't registered unless a wallet is loaded. But
         // this error is being kept as a precaution, because it's possible in

diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -50,6 +50,11 @@ void RemoveWallet(CWallet* wallet)
     if (i != vpwallets.end()) vpwallets.erase(i);
 }
 
+bool HasWallets()
+{
+  return !vpwallets.empty();
+}
+
 std::vector<CWallet*> GetWallets()
 {
     return vpwallets;

diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -34,6 +34,7 @@
 
 void AddWallet(CWallet* wallet);
 void RemoveWallet(CWallet* wallet);
+bool HasWallets();
 std::vector<CWallet*> GetWallets();
 CWallet* GetWallet(const std::string& name);