qt: PeerTableModel: Fix potential deadlock. #4296

bitcoin · Jun 6, 2014 · b917555 · b917555
1 parent 65f78a1
commit b917555
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/qt/peertablemodel.cpp b/src/qt/peertablemodel.cpp
@@ -49,8 +49,8 @@ class PeerTablePriv
 
     /** Pull a full list of peers from vNodes into our cache */
     void refreshPeers() {
-        TRY_LOCK(cs_vNodes, lockNodes);
         {
+            TRY_LOCK(cs_vNodes, lockNodes);
             if (!lockNodes)
             {
                 // skip the refresh if we can't immediately get the lock
@@ -70,8 +70,8 @@ class PeerTablePriv
         }
 
         // if we can, retrieve the CNodeStateStats for each node.
-        TRY_LOCK(cs_main, lockMain);
         {
+            TRY_LOCK(cs_main, lockMain);
             if (lockMain)
             {
                 BOOST_FOREACH(CNodeCombinedStats &stats, cachedNodeStats)