doc: Document CTxMemPoolEntry copy and move constructors

bitcoin · Feb 10, 2024 · c34dcea · c34dcea
1 parent a54c764
commit c34dcea
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/kernel/mempool_entry.h b/src/kernel/mempool_entry.h
@@ -127,8 +127,11 @@ class CTxMemPoolEntry
           nModFeesWithAncestors{nFee},
           nSigOpCostWithAncestors{sigOpCost} {}
 
+    // Prohibit accidental copies that might invalidate references from parent
+    // and child transactions, or lead to unsafe usage of mapTx.iterator_to.
     CTxMemPoolEntry(ExplicitCopyTag, const CTxMemPoolEntry& entry) : CTxMemPoolEntry(entry) {}
     CTxMemPoolEntry& operator=(const CTxMemPoolEntry&) = delete;
+    // The move constructor is already implicitly deleted, so be explicit about it.
     CTxMemPoolEntry(CTxMemPoolEntry&&) = delete;
     CTxMemPoolEntry& operator=(CTxMemPoolEntry&&) = delete;