Skip to content

Commit

Permalink
rpcwallet: use EnsureWalletIsUnlocked() where possible
Browse files Browse the repository at this point in the history
- replaces a pwalletMain->IsLocked() check
- in keypoolrefill init kpSize to 0 as we have the logic to determine max
  kpSize in pwalletMain->TopUpKeyPool() anyway
  • Loading branch information
Philip Kaufmann committed Dec 9, 2013
1 parent 6694f4a commit f914c7a
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/rpcwallet.cpp
Expand Up @@ -334,8 +334,7 @@ Value sendtoaddress(const Array& params, bool fHelp)
if (params.size() > 3 && params[3].type() != null_type && !params[3].get_str().empty())
wtx.mapValue["to"] = params[3].get_str();

if (pwalletMain->IsLocked())
throw JSONRPCError(RPC_WALLET_UNLOCK_NEEDED, "Error: Please enter the wallet passphrase with walletpassphrase first.");
EnsureWalletIsUnlocked();

string strError = pwalletMain->SendMoneyToDestination(address.Get(), nAmount, wtx);
if (strError != "")
Expand Down Expand Up @@ -1657,15 +1656,15 @@ Value keypoolrefill(const Array& params, bool fHelp)
+ HelpExampleRpc("keypoolrefill", "")
);

unsigned int kpSize = max(GetArg("-keypool", 100), (int64_t) 0);
// 0 is interpreted by TopUpKeyPool() as the default keypool size given by -keypool
unsigned int kpSize = 0;
if (params.size() > 0) {
if (params[0].get_int() < 0)
throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, expected valid size");
kpSize = (unsigned int) params[0].get_int();
throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, expected valid size.");
kpSize = (unsigned int)params[0].get_int();
}

EnsureWalletIsUnlocked();

pwalletMain->TopUpKeyPool(kpSize);

if (pwalletMain->GetKeyPoolSize() < kpSize)
Expand Down

0 comments on commit f914c7a

Please sign in to comment.