Skip to content

Commit

Permalink
fuzz: Remove option --export_coverage from test_runner
Browse files Browse the repository at this point in the history
The coverage statistics are not stable across clang versions
  • Loading branch information
MarcoFalke committed Mar 10, 2020
1 parent aaaa055 commit fa3fa27
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions test/fuzz/test_runner.py
Expand Up @@ -29,11 +29,6 @@ def main():
default="INFO",
help="log events at this level and higher to the console. Can be set to DEBUG, INFO, WARNING, ERROR or CRITICAL. Passing --loglevel DEBUG will output all logs to console.",
)
parser.add_argument(
'--export_coverage',
action='store_true',
help='If true, export coverage information to files in the seed corpus',
)
parser.add_argument(
'--valgrind',
action='store_true',
Expand Down Expand Up @@ -131,7 +126,6 @@ def main():
corpus=args.seed_dir,
test_list=test_list_selection,
build_dir=config["environment"]["BUILDDIR"],
export_coverage=args.export_coverage,
use_valgrind=args.valgrind,
)

Expand All @@ -152,7 +146,7 @@ def merge_inputs(*, corpus, test_list, build_dir, merge_dir):
logging.debug('Output: {}'.format(output))


def run_once(*, corpus, test_list, build_dir, export_coverage, use_valgrind):
def run_once(*, corpus, test_list, build_dir, use_valgrind):
for t in test_list:
corpus_path = os.path.join(corpus, t)
if t in FUZZERS_MISSING_CORPORA:
Expand All @@ -177,13 +171,6 @@ def run_once(*, corpus, test_list, build_dir, export_coverage, use_valgrind):
logging.info(e.stderr)
logging.info("Target \"{}\" failed with exit code {}: {}".format(t, e.returncode, " ".join(args)))
sys.exit(1)
if not export_coverage:
continue
for l in output.splitlines():
if 'INITED' in l:
with open(os.path.join(corpus, t + '_coverage'), 'w', encoding='utf-8') as cov_file:
cov_file.write(l)
break


def parse_test_list(makefile):
Expand Down

0 comments on commit fa3fa27

Please sign in to comment.