Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--disable-lcov complains there's no lcov #10828

Closed
janstary opened this issue Jul 14, 2017 · 2 comments · Fixed by #11611
Closed

--disable-lcov complains there's no lcov #10828

janstary opened this issue Jul 14, 2017 · 2 comments · Fixed by #11611
Labels
Build system

Comments

@janstary
Copy link

This is 0.14.2 being built on openBSD 6.1-current.

env AUTOCONF_VERSION=2.69  AUTOMAKE_VERSION=1.15 sh autogen.sh
./configure --prefix=$HOME --mandir=$HOME/man --disable-tests --disable-gui-tests --disable-wallet --with-gui=no --disable-lcov CC=egcc CXX=eg++

...
configure: error: "lcov testing requested but lcov not found"
@achow101
Copy link
Member

lcov is disabled by default. Using --disable-lcov will toggle the lcov setting, which is defaulted to no, so it will set it to yes. If you don't want to use lcov, then don't have any option involving lcov.

@janstary
Copy link
Author

Exactly. If --disable-lcov enables lcov, it's a bug in the configure script.

@fanquake fanquake mentioned this issue Nov 5, 2017
Merged
laanwj added a commit that referenced this issue Nov 6, 2017
@laanwj
Merge #11611: [build] Don't fail when passed --disable-lcov and lcov …
0e70791 
…isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes #10828
  As pointed out in #10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Dec 22, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
052b0ed 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 2, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
017a0fe 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 4, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
240c7c8 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
186855e 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
f3eb28a 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
db7c195 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
bf5e65b 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
ab9f771 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
dca5998 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 16, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
bbd89c5 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
gades pushed a commit to cosanta/cosanta-core that referenced this issue Jun 26, 2021
@laanwj
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
059348e 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
gades pushed a commit to cosanta/cosanta-core that referenced this issue Mar 16, 2022
@laanwj @gades
Merge bitcoin#11611: [build] Don't fail when passed --disable-lcov an…
007f3b1 
…d lcov isn't available

223a4aa [build] Don't fail when passed --disable-lcov and lcov isn't available (fanquake)

Pull request description:

  Fixes bitcoin#10828
  As pointed out in bitcoin#10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):
  ```
  ./configure --disable-lcov
  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes
  configure: error: "lcov testing requested but lcov not found"
  ```

  cc @janstary

Tree-SHA512: 606fdbddae67e72fff175f2f34e2c9af4e6972d40d5e1ec5c5d8be5051a728e5b16c35cfd856da0c0ce81dcab9db154a4937b1a6ca1e0233b6e160f2f4362002
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[build] Don't fail when passed --disable-lcov and lcov isn't available fanquake/bitcoin
3 participants
@fanquake @janstary @achow101