Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoS prevention: check for duplicate transactions earlier #1167

Closed
gavinandresen opened this issue Apr 30, 2012 · 0 comments
Closed

DoS prevention: check for duplicate transactions earlier #1167

gavinandresen opened this issue Apr 30, 2012 · 0 comments
Labels
Bug
Milestone
0.6.1

Comments

@gavinandresen
Copy link
Contributor

If you include the same transaction in a block twice the block is rejected by ConnectInputs()... but that is only done after fetching transactions from disk, checking signatures, etc. And it doesn't trigger the DoS prevention code.

There should be a check for duplicate transactions in CheckBlock(), so blocks with duplicate transactions are rejected early and trigger the DoS code.
luke-jr pushed a commit to luke-jr/bitcoin that referenced this issue May 20, 2012
@gavinandresen @luke-jr
Check earlier for blocks with duplicate transactions. Fixes bitcoin#1167
ad5a4c7
luke-jr pushed a commit to luke-jr/bitcoin that referenced this issue May 20, 2012
@gavinandresen @luke-jr
Check earlier for blocks with duplicate transactions. Fixes bitcoin#1167
6a89317
coblee pushed a commit to litecoin-project/litecoin that referenced this issue Jul 17, 2012
@gavinandresen
Check earlier for blocks with duplicate transactions. Fixes bitcoin#1167
43080f2
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this issue Dec 5, 2017
@tgflynn @UdjinM6
Governance object deletion changes (bitcoin#1167)
ecdc160 
* Increase quorum for object deletion to 2/3 of MN network

* Implement expiration of watchdog objects

* Remove objects from the watchdog map itself

* Message fix for invalid objects
lateminer pushed a commit to lateminer/bitcoin that referenced this issue Jan 22, 2019
@gandrewstone
Merge pull request bitcoin#1167 from awemany/sa-simplifications
5220fc7 
Fixes and simplifications from static analysis
lateminer pushed a commit to lateminer/bitcoin that referenced this issue Dec 25, 2019
@furszy
Merge bitcoin#1167: [Trivial] Remove time offset warning when it gets…
fc4ffcf 
… back within range

c24d2b1 [Trivial] Clean time offset warning when it gets back within range (random-zebra)

Pull request description:

  Simple update (related to bitcoin#1128 and bitcoin#1138).
  Clear `strMiscWarning` if the median gets back within the offset limit (after being off, for example during startup when the node has very few time samples).

ACKs for top commit:
  Fuzzbawls:
    utACK c24d2b1
  furszy:
    utACK c24d2b1

Tree-SHA512: c0d4b206eb85cd6d6ba580a3e2b74d46b7518225733c88412cbf810f863910455b3daa35c72c9442d02a80593d79916f83eed26a2ca26903596f2a0182558906
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.6.1
Development

No branches or pull requests
1 participant
@gavinandresen