-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa: Add emojis to test_runner path and wallet filename #13859
Conversation
Concept ACK I feel like this is an opportunity to use ₿ somewhere. |
Concept ACK |
fa47f30
to
fa5a3f5
Compare
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
utACK fa5a3f51cc4b3dae2f134fae1745f392ca6e5e47 |
cffffff
to
fa12af2
Compare
utACK fa5a3f51cc4b3dae2f134fae1745f392ca6e5e47 – the macos build failed with a timeout, maybe restart the build? |
fa12af2
to
5e17777
Compare
utACK 5e17777. |
utACK 5e17777 |
💜-ACK 5e17777 |
5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
This seems to be causing travis errors:
https://travis-ci.org/bitcoin/bitcoin/jobs/402357380#L3946 I see same error locally if I run |
@ryanofsky The travis error is due to a travis bug, where it wouldn't use the most recent travis yaml when a build is reset/rerun. Locally, you'd have to pick a language setting that is UTF-8 or set |
This is solved in #13863 |
I like this and think it's fun... but is it possible we can revert this? It breaks clipboard copy-paste behavior on my system so it makes it a bit annoying to copy the directiory to examine the directory on failed test. It's a minor annoyance, but idk if it's worth it? |
@JeremyRubin We should absolutely test wallet behaviour for non-ascii directory and file paths. Especially given that it was broken in the past and some Bitcoin Core users have a non-ascii name. |
Ah I guess I mean just the test runner part.
I'm fine with it being non ASCII, but copy paste highlighting treats the
Emojis as whitespace on my system which makes it a bit more painful to
inspect the tmp dir when debugging.
…On Thu, Nov 7, 2019, 6:11 AM MarcoFalke ***@***.***> wrote:
@JeremyRubin <https://github.com/JeremyRubin> We should absolutely test
wallet behaviour for non-ascii directory and file paths. Especially given
that it was broken in the past and some Bitcoin Core users have a non-ascii
name.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13859?email_source=notifications&email_token=AAGYN6Y5KFF6R4QEPPK3ON3QSQOX5A5CNFSM4FNU3AR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDMQXLA#issuecomment-551095212>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGYN6ZLWGCNPJKXSAVAXF3QSQOX5ANCNFSM4FNU3ARQ>
.
|
The test runner path defines the root dir for the temp test dirs, and some of our wallets use absolute paths that are not in the datadir or wallet dir. So the root dir is the only place where an emoji could be injected to make the path non-ascii. Have you reported the clipboard bug upstream? |
I have the same problem with gnome terminal. They are really stubborn about their UI and in the past removed the ability to customize this behavior: https://bugzilla.gnome.org/show_bug.cgi?id=730632 But maybe there is a way to customize it again: Though I think my real solution should just be to get a better terminal. Or maybe github could shadowban Marco's emojis so only he can be amused by them and everybody else will just wonder why he's so happy all the time. |
Maybe we could add an |
Summary: Backport of core [[bitcoin/bitcoin#13859 | PR13859]]. This looks funny, but is here to add some coverage of the utf-8 support. Test Plan: ninja check-functional Reviewers: #bitcoin_abc, majcosta Reviewed By: majcosta Differential Revision: https://reviews.bitcoinabc.org/D5958
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
…lename 5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (bitcoin#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
Now that wallet filenames are properly quoted when used for rpc (#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name.
Should add unicode coverage to
listwallets
wallet.getwalletinfo
(un)loadwallet