Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin-Qt: Tx fee weirdness #1570

Closed
Diapolo opened this issue Jul 8, 2012 · 7 comments
Closed

Bitcoin-Qt: Tx fee weirdness #1570

Diapolo opened this issue Jul 8, 2012 · 7 comments

Comments

@Diapolo
Copy link

Diapolo commented Jul 8, 2012

Using current Git master and want to send all coins from a wallet to another one.

  • try to send 0.0128772 BTC
  • message that a Tx fee of 0.001 BTC is needed, so I can't send
  • try to send 0.0113772 BTC (All coins - Tx fee of 0.001 BTC)
  • message that Tx is over size and I need a Tx fee of 0.0005

Is there a way to get the final Tx fee sum in one info message?

@gmaxwell
Copy link
Contributor

gmaxwell commented Jul 8, 2012

0.0128772 - 0.001 = 0.0118772 > 0.0113772.

By lowering it more than you needed to you left an input out, making the transaction smaller... thus needing less fee. I don't see any way of solving that directly.

What I think would help would be options to "take any fee out of the amount being sent" which would remove that problem since the coin selection wouldn't change, and would do exactly what you wanted for the 'send all my coins case'. Also, an option to "round sent amount up, up to X btc", useful when sending to another account of yours, would also tend to reduce fees fairly considerably... but I don't know how UI for that stuff could be done in a non-confusing way.

@Diapolo
Copy link
Author

Diapolo commented Jul 8, 2012

At least a "send all and subtract the Tx fee"-option should be not that confusing in terms of UX as it's rather straight forward. I never looked at that part of the code, but perhaps that get's one of my next "targets".

@gmaxwell
Copy link
Contributor

gmaxwell commented Jul 8, 2012

@Diapolo Perhaps just a third option on the fee question? "yes, no, take it out of the amount being sent" ?

@laanwj
Copy link
Member

laanwj commented Jul 9, 2012

Or add a checkbox/combobox, otherwise you'd end up with a lot of text on a button.

In banking software this is generally posed as "who pays the fee", you or the recipient.

Maybe show a warning when the sender wants to pay the fee but there isn't enough balance to add the fee.

BTW what if the fee counts towards the amount being sent, but it consumes the entire amount so that the recipient doesn't receive anything? Can this happen?

@gmaxwell
Copy link
Contributor

gmaxwell commented Jul 9, 2012

@laanwj It could certainly happen if the implementation was simplistic and if the payment was small (0.05 or less) or the user manually set a high BTC/KB. Good catch. I'm not quite sure how to avoid that without further complexifying the UI.

@laanwj
Copy link
Member

laanwj commented Jul 1, 2014

Please help testing #4331, it tries to solve this.

@laanwj laanwj closed this as completed Jul 31, 2014
@laanwj
Copy link
Member

laanwj commented Jul 31, 2014

Closing as duplicate of #2724.
Note: that pull (#4331) still desperately needs testing, if no one tests it and verifies the functionality, it cannot be merged.

laanwj pushed a commit to laanwj/bitcoin that referenced this issue Mar 5, 2015
Fixes bitcoin#2724 and bitcoin#1570.

Adds the
automatically-subtract-the-fee-from-the-amount-and-send-whats-left
feature to the GUI and RPC (sendtoaddres,sendfrom,sendmany).
laanwj pushed a commit to laanwj/bitcoin that referenced this issue Mar 13, 2015
Fixes bitcoin#2724 and bitcoin#1570.

Adds the
automatically-subtract-the-fee-from-the-amount-and-send-whats-left
feature to the GUI and RPC (sendtoaddress,sendmany).
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this issue Dec 5, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this issue May 6, 2020
…ng insane fees

b8fad43 [Trivial] Fix wording: "must be above" to "must be at least" (random-zebra)
03be61e [GUI] Custom fee, min amount validation. (furszy)
d063a7f [GUI] SendCustomFeeDialog: prevent user from saving insane fees (random-zebra)

Pull request description:

  Based on top of:
  - [x] bitcoin#1574
  - [x] bitcoin#1575
  - [x] bitcoin#1580

  Straightforward update, as per title.
  Closes bitcoin#1570

  EDIT: cherrypicked a commit from @furszy , for min fee validation too.

ACKs for top commit:
  furszy:
    ACK b8fad43
  Fuzzbawls:
    ACK b8fad43

Tree-SHA512: 87be1f59e82f144b8330b18aafedcdd46b8b2c340c29d2a8f21efe9293899643d4b564666e673d54cade8d0e4a6be0fd17b1f6e1af4eeb9a767e363a509e9612
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants