Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depends: File-based logging for individual packages #16368

Closed
dongcarl opened this issue Jul 10, 2019 · 6 comments · Fixed by #19952
Closed

depends: File-based logging for individual packages #16368

dongcarl opened this issue Jul 10, 2019 · 6 comments · Fixed by #19952
Labels
Build system

Comments

@dongcarl
Copy link
Contributor

We should have file-based logging for each depends package so that:

  1. We can diff logs to spot regressions when changing our build script / updating packages.
  2. Travis has a line limit for output, so when running on Travis, we could withhold logs until we notice a non-zero exit code, then print stdout/stderr.
@dongcarl
Copy link
Contributor Author

Related: #16354

@fanquake
Copy link
Member

Concept ACK

maflcko pushed a commit to maflcko/bitcoin-core that referenced this issue May 28, 2020
ci: Only print depends output on fail
28254d5 
See bitcoin#16368
@maflcko
Copy link
Member

maflcko commented May 28, 2020

@dongcarl This "good first issue" is open for almost a year. Maybe people are missing hints and pointers how this can be solved?

@maflcko
Copy link
Member

maflcko commented May 28, 2020

(Sorry, I just realized I made this a good first issue, not you)

@maflcko maflcko mentioned this issue Jun 3, 2020
Merged
@maflcko
Copy link
Member

maflcko commented Jun 3, 2020

If someone works on this issue, it might be good to also revert the hacky workaround in commit fa0cc02

@maflcko maflcko mentioned this issue Jun 11, 2020
Merged
hebasto added a commit to hebasto/bitcoin that referenced this issue Aug 30, 2020
@hebasto
ci: Drop Travis workaround for bitcoin#16368
961a72a
@hebasto hebasto mentioned this issue Sep 13, 2020
Merged
@hebasto
Copy link
Member

hebasto commented Sep 13, 2020

@MarcoFalke

If someone works on this issue, it might be good to also revert the hacky workaround in commit fa0cc02

Done in #19952.

solderzzc added a commit to SharpAI/DeepCamera that referenced this issue Oct 9, 2020
@solderzzc
Temporary workaround for bitcoin/bitcoin#16368
e2f1995
@curtcurt380 curtcurt380 mentioned this issue Dec 17, 2020
Merged
@laanwj laanwj closed this as completed in e14f0fa Apr 14, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Apr 14, 2022
@laanwj
Merge bitcoin#19952: build, ci: Add file-based logging for individual…
58b98f1 
… packages

86c2889 ci: Make log verbose in error case only (Hennadii Stepanov)
7f65088 depends: Add file-based logging for individual packages (Hennadii Stepanov)

Pull request description:

  This PR adds file-based logging for individual packages in depends. To use this feature one should provide `LOG=1`.

  A log file is printed out automatically in case of a build error. After successful build log files are being moved along with package archives:
  ```
  $ make -C depends HOST=x86_64-w64-mingw32 LOG=1
  $ find ./depends/built/x86_64-w64-mingw32 -name '*.log' | sort
  ./depends/built/x86_64-w64-mingw32/bdb/bdb-4.8.30-5100a099801.log
  ./depends/built/x86_64-w64-mingw32/boost/boost-1_71_0-313f82dc7de.log
  ./depends/built/x86_64-w64-mingw32/libevent/libevent-2.1.12-stable-3fa27048d5e.log
  ./depends/built/x86_64-w64-mingw32/libnatpmp/libnatpmp-4536032ae32268a45c073a4d5e91bbab4534773a-9db4850dd32.log
  ./depends/built/x86_64-w64-mingw32/miniupnpc/miniupnpc-2.2.2-75d9a1807e0.log
  ./depends/built/x86_64-w64-mingw32/native_b2/native_b2-1_71_0-3bf253c19bf.log
  ./depends/built/x86_64-w64-mingw32/qrencode/qrencode-3.4.4-dfac87af599.log
  ./depends/built/x86_64-w64-mingw32/qt/qt-5.15.2-9304e03d3ac.log
  ./depends/built/x86_64-w64-mingw32/sqlite/sqlite-3320100-455acafa7be.log
  ./depends/built/x86_64-w64-mingw32/zeromq/zeromq-4.3.1-5ff627ec84a.log
  ```

  An example of CI tasks with package build errors -- https://cirrus-ci.com/task/5275741788045312

  Closes bitcoin#16368.

ACKs for top commit:
  laanwj:
    Tested ACK 86c2889

Tree-SHA512: 497f2146fd2e38c952124aecfd80ebb42be22bbc5dc59521491545f4465fc38f23da7787a0caea5686b7c30aa862f2b0c02092ae3fe863e80a5ddd14b3d324b9
@bitcoin bitcoin locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build, ci: Add file-based logging for individual packages hebasto/bitcoin
4 participants
@fanquake @dongcarl @maflcko @hebasto