Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: sendtoaddress and sendmany should return PSBT for watch-only wallet #18180

Closed
Sjors opened this issue Feb 19, 2020 · 4 comments
Closed

rpc: sendtoaddress and sendmany should return PSBT for watch-only wallet #18180

Sjors opened this issue Feb 19, 2020 · 4 comments
Labels

Comments

@Sjors
Copy link
Member

Sjors commented Feb 19, 2020

Similar to bumpfee #16373, I would like sendtoaddress and sendmany to return a PSBT when used on a watch-only wallet. These methods are easier to use than walletcreatefundedpsbt.

I added this functionally as part of external signer support in #16546, which helps keep that PR short. But I think it makes sense as a standalone PR.

@Sjors Sjors added the Feature label Feb 19, 2020
@Sjors
Copy link
Member Author

Sjors commented Feb 19, 2020

Probably best built on top of #18115.

cc @instagibbs, @achow101: how does this fit in the (Legacy/Descriptor)ScriptPubKeyMan architecture? Right now these methods use an RPC helper SendMoney, which in turn calls wallet->CreateTransaction and pwallet->CommitTransaction(). What's the appropriate place to make it call either FillPSBT() or SignTransaction() on the ScriptPubKeyMan?

@Sjors
Copy link
Member Author

Sjors commented Feb 21, 2020

For sendmany the change is pretty straight-forward, see 2a04b96

@promag
Copy link
Member

promag commented Mar 15, 2020

From #16378

This paves the way for deprecating sendtoaddress and sendmany though there's no rush. The only missing feature compared to these older methods is adding labels to a destination address.

But here you want to add more features to these RPC 😅

@Sjors
Copy link
Member Author

Sjors commented Mar 17, 2020

Things change quickly! Closing this.

@Sjors Sjors closed this as completed Mar 17, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants