-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet: Replace -zapwallettxes with wallet tool command #19700
Conversation
Concept ACK! I think this is the best solution if we decide to not remove the functionality wholesale. |
b8742c8
to
5739465
Compare
If we are keeping metadata, write the zapped txs in zaptx records. Remove them after fetching the metadata.
Removes the startup option and replaces it with an error message telling users to use the RPC instead.
5739465
to
f7604a5
Compare
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Seems the we have consensus to move forward in #19671, so I'm going to close this PR. |
3340dba Remove -zapwallettxes (Andrew Chow) Pull request description: It's not clear what use there is to keeping `-zapwallettxes` given that it's intended usage has been superseded by `abandontransaction`. So this removes it outright. Alternative to #19700 ACKs for top commit: meshcollider: utACK 3340dba fanquake: ACK 3340dba - remaining manpage references will get cleaned up pre-release. Tree-SHA512: 3e58e1ef6f4f94894d012b93e88baba3fb9c2ad75b8349403f9ce95b80b50b0b4f443cb623cf76c355930db109f491b3442be3aa02972e841450ce52cf545fc8
3340dba Remove -zapwallettxes (Andrew Chow) Pull request description: It's not clear what use there is to keeping `-zapwallettxes` given that it's intended usage has been superseded by `abandontransaction`. So this removes it outright. Alternative to bitcoin#19700 ACKs for top commit: meshcollider: utACK 3340dba fanquake: ACK 3340dba - remaining manpage references will get cleaned up pre-release. Tree-SHA512: 3e58e1ef6f4f94894d012b93e88baba3fb9c2ad75b8349403f9ce95b80b50b0b4f443cb623cf76c355930db109f491b3442be3aa02972e841450ce52cf545fc8
Replaces the
-zapwallettxes
startup option with azapwallettxes
command in the wallet tool.To preserve the transaction metadata, using
zapwallettxes
rewrites the transactions as azaptx
record and removes the originaltx
record.bestblock
is also reset to null to trigger a rescan. On loading the wallet, a rescan will be triggered. If anyzaptx
records were found, then the metadata from those records is copied to the new tx. Allzaptx
records are removed after loading. If metadata is not kept (by using-keepmeta=0
in the wallet tool), then nozaptx
records will be created.Lastly
-zapwallettxes
is replaced with an error telling users to use the wallet tool command instead.Alternative to #19653 and #19671