Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes #19797

Merged
merged 1 commit into from Aug 28, 2020
Merged

net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes #19797

merged 1 commit into from Aug 28, 2020

Conversation

i-rme
Copy link
Contributor

@i-rme i-rme commented Aug 24, 2020 •
edited

The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

Credits for discovering this go to sipa in #19628 (comment)

Thanks for the attention!

@fanquake fanquake added the P2P label Aug 24, 2020
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 25, 2020 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@DrahtBot DrahtBot mentioned this pull request Aug 25, 2020
Merged
@instagibbs
Copy link
Member

Can modern Core nodes even talk to those nodes on p2p?

utACK 2c1f59c

@jonatack
Copy link
Contributor

Can modern Core nodes even talk to those nodes on p2p?

Nope: #19628 (comment)

@jonatack
Copy link
Contributor

@i-rme suggest updating the PR description to reference #19628 (comment) rather than twitter.

@i-rme
Copy link
Contributor Author

i-rme commented Aug 25, 2020

@i-rme suggest updating the PR description to reference #19628 (comment) rather than twitter.

Added that reference since I was not aware of it before.

@jonatack
Copy link
Contributor

Thanks for updating. You'll need to rebase.

@i-rme
Copy link
Contributor Author

i-rme commented Aug 25, 2020

Rebased

vasild
vasild approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dba98c8

jonatack
jonatack reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK dba98c8

@practicalswift
Copy link
Contributor

Concept ACK: I'm afraid we'll have to deviate slightly from Satoshi's original vision here!

@maflcko maflcko changed the title net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node … net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes Aug 26, 2020
@laanwj
Copy link
Member

laanwj commented Aug 27, 2020

Code review ACK
Please remove the @ from your commit message (it leads to the @'ed people getting lots of notifications).

@i-rme
Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node …
7b6d0f1 
…messages

The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

Credits for discovering this go to sipa.
@i-rme
Copy link
Contributor Author

i-rme commented Aug 28, 2020

Removed the @ from the commit message to avoid notifications.

vasild
vasild approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7b6d0f1

@sipa
Copy link
Member

sipa commented Aug 28, 2020

utACK 7b6d0f1

@maflcko maflcko merged commit 5edef20 into bitcoin:master Aug 28, 2020
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin#19797: net: Remove old check for 3-byte shifted IP addr…
f67aba4 
…esses from pre-0.2.9 nodes

7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME))

Pull request description:

  The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

  This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

  Credits for discovering this go to sipa in bitcoin#19628 (comment)

  Thanks for the attention!

ACKs for top commit:
  sipa:
    utACK 7b6d0f1
  vasild:
    ACK 7b6d0f1

Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#19797: net: Remove old check for 3-byte shifted IP addr…
69e2115 
…esses from pre-0.2.9 nodes

7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME))

Pull request description:

  The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

  This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

  Credits for discovering this go to sipa in bitcoin#19628 (comment)

  Thanks for the attention!

ACKs for top commit:
  sipa:
    utACK 7b6d0f1
  vasild:
    ACK 7b6d0f1

Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin#19797: net: Remove old check for 3-byte shifted IP addr…
ae0ae43 
…esses from pre-0.2.9 nodes

7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME))

Pull request description:

  The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

  This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

  Credits for discovering this go to sipa in bitcoin#19628 (comment)

  Thanks for the attention!

ACKs for top commit:
  sipa:
    utACK 7b6d0f1
  vasild:
    ACK 7b6d0f1

Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#19797: net: Remove old check for 3-byte shifted IP addr…
10c3d63 
…esses from pre-0.2.9 nodes

7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME))

Pull request description:

  The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

  This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

  Credits for discovering this go to sipa in bitcoin#19628 (comment)

  Thanks for the attention!

ACKs for top commit:
  sipa:
    utACK 7b6d0f1
  vasild:
    ACK 7b6d0f1

Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#19797: net: Remove old check for 3-byte shifted IP addr…
1988592 
…esses from pre-0.2.9 nodes

7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME))

Pull request description:

  The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

  This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

  Credits for discovering this go to sipa in bitcoin#19628 (comment)

  Thanks for the attention!

ACKs for top commit:
  sipa:
    utACK 7b6d0f1
  vasild:
    ACK 7b6d0f1

Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@PastaPastaPasta
Merge bitcoin#19797: net: Remove old check for 3-byte shifted IP addr…
1ff7090 
…esses from pre-0.2.9 nodes

7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME))

Pull request description:

  The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

  This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

  Credits for discovering this go to sipa in bitcoin#19628 (comment)

  Thanks for the attention!

ACKs for top commit:
  sipa:
    utACK 7b6d0f1
  vasild:
    ACK 7b6d0f1

Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 16, 2021
@PastaPastaPasta
Merge bitcoin#19797: net: Remove old check for 3-byte shifted IP addr…
5dc3974 
…esses from pre-0.2.9 nodes

7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME))

Pull request description:

  The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

  This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

  Credits for discovering this go to sipa in bitcoin#19628 (comment)

  Thanks for the attention!

ACKs for top commit:
  sipa:
    utACK 7b6d0f1
  vasild:
    ACK 7b6d0f1

Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 17, 2021
@i-rme @PiRK
Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node …
f13fc65 
…messages

Summary:
The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

Credits for discovering this go to sipa.

This is a backport of [[bitcoin/bitcoin#19797 | core#19797]]

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10134
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonatack jonatack jonatack left review comments

@vasild vasild vasild approved these changes

Assignees
No one assigned
Labels
P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@i-rme @DrahtBot @instagibbs @jonatack @practicalswift @laanwj @sipa @vasild @fanquake @maflcko