net: change CNetAddr::ip to have flexible size #19628

vasild · 2020-07-30T15:33:51Z

(chopped off from #19031 to ease review)

Before this change CNetAddr::ip was a fixed-size array of 16 bytes,
not being able to store larger addresses (e.g. TORv3) and encoded
smaller ones as 16-byte IPv6 addresses.

Change its type to prevector, so that it can hold larger addresses and
do not disguise non-IPv6 addresses as IPv6. So the IPv4 address
1.2.3.4 is now encoded as 01020304 instead of
00000000000000000000FFFF01020304.

Rename CNetAddr::ip to CNetAddr::m_addr because it is not an "IP" or
"IP address" (TOR addresses are not IP addresses).

In order to preserve backward compatibility with serialization (where
e.g. 1.2.3.4 is serialized as 00000000000000000000FFFF01020304)
introduce CNetAddr dedicated legacy serialize/unserialize methods.

Adjust CSubNet accordingly. Still use CSubNet::netmask[] of fixed 16
bytes, but use the first 4 for IPv4 (not the last 4). Do not accept
invalid netmasks that have 0-bits followed by 1-bits and only allow
subnetting for IPv4 and IPv6.

Co-authored-by: Carl Dong contact@carldong.me

jonatack · 2020-07-30T15:43:36Z

Concept ACK

vasild · 2020-07-30T16:01:00Z

Filtered code coverage report (files not modified by this PR are omitted and not modified lines in files that are otherwise modified are dimmed).

List of modified and not covered lines.

DrahtBot · 2020-07-30T20:25:25Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes #19797 (net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node … by i-rme)
refactor: make EncodeBase{32,64} consume Spans #19687 (refactor: make EncodeBase{32,64} consume Spans by theStack)
net: Make DNS lookup mockable, add fuzzing harness #19415 (net: Make DNS lookup mockable, add fuzzing harness by practicalswift)
addrman: improve performance by using more suitable containers #18722 (addrman: improve performance by using more suitable containers by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

src/netaddress.h

src/netaddress.cpp

src/netaddress.h

vasild · 2020-08-05T11:04:07Z

Rebased to resolve a conflict.

vasild · 2020-08-05T11:33:20Z

Applied review suggestions.

src/test/fuzz/asmap.cpp

src/netaddress.cpp

vasild · 2020-08-10T13:10:45Z

Fixed Windows build and changed SetLegacyIPv6() to take a ~~Spam~~Span argument.

vasild · 2020-08-10T20:19:38Z

s/IPv4_IN_IPv6_PREFIX/IPV4_IN_IPV6_PREFIX/ also in comment, was missed during the rename.

vasild · 2020-08-11T12:05:54Z

Rebased just to restart Travis.

jonatack

Glad to see progress on BIP155/addrv2 with the imminent Tor v2 deprecation in a month with planned obsolescence on July 15, 2021.

ACK bfe7d1b a couple hours of code review -- tried to distinguish the many straightforward-looking and good mechanical changes from the critical ones as they are all smooshed together, however I will continue looking at this code and it's good to have it merged not late in the release cycle--, clean debug builds on gcc Debian 10.1.0, running a node since a day now with the change.

A few comments below that can be ignored or left for a follow-up unless you decide to retouch or take some of them now.

src/netaddress.h

src/netaddress.cpp

886be97 Ignore incorrectly-serialized banlist.dat entries (Pieter Wuille) 883cea7 Restore compatibility with old CSubNet serialization (Pieter Wuille) Pull request description: #19628 changed CSubNet for IPv4 netmasks, using the first 4 bytes of `netmask` rather than the last 4 to store the actual mask. Unfortunately, CSubNet objects are serialized on disk in banlist.dat, breaking compatibility with existing banlists (and bringing them into an inconsistent state where entries reported in `listbanned` cannot be removed). Fix this by reverting to the old format (just for serialization). Also add a sanity check to the deserializer so that nonsensical banlist.dat entries are ignored (which would otherwise be possible if someone added IPv4 entries after #19628 but without this PR). Reported by Greg Maxwell. ACKs for top commit: laanwj: Code review ACK 886be97 vasild: ACK 886be97 Tree-SHA512: d3fb91e8ecd933406e527187974f22770374ee2e12a233e7870363f52ecda471fb0b7bae72420e8ff6b6b1594e3037a5115984c023dbadf38f86aeaffcd681e7

…tion 886be97 Ignore incorrectly-serialized banlist.dat entries (Pieter Wuille) 883cea7 Restore compatibility with old CSubNet serialization (Pieter Wuille) Pull request description: bitcoin#19628 changed CSubNet for IPv4 netmasks, using the first 4 bytes of `netmask` rather than the last 4 to store the actual mask. Unfortunately, CSubNet objects are serialized on disk in banlist.dat, breaking compatibility with existing banlists (and bringing them into an inconsistent state where entries reported in `listbanned` cannot be removed). Fix this by reverting to the old format (just for serialization). Also add a sanity check to the deserializer so that nonsensical banlist.dat entries are ignored (which would otherwise be possible if someone added IPv4 entries after bitcoin#19628 but without this PR). Reported by Greg Maxwell. ACKs for top commit: laanwj: Code review ACK 886be97 vasild: ACK 886be97 Tree-SHA512: d3fb91e8ecd933406e527187974f22770374ee2e12a233e7870363f52ecda471fb0b7bae72420e8ff6b6b1594e3037a5115984c023dbadf38f86aeaffcd681e7

Summary: ``` A netmask that contains 1-bits after 0-bits (the 1-bits are not contiguous on the left side) is invalid [1] [2]. The code before this PR used to parse and accept such non-left-contiguous netmasks. However, a coming change that will alter `CNetAddr::ip` to have flexible size would make juggling with such netmasks more difficult, thus drop support for those. [1] https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#Subnet_masks [2] https://tools.ietf.org/html/rfc4632#section-5.1 ``` Partial backport (1/2) of core [[bitcoin/bitcoin#19628 | PR19628]]: bitcoin/bitcoin@1ea57ad Depends on D9172. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9175

Summary: ``` Before this change `CNetAddr::ip` was a fixed-size array of 16 bytes, not being able to store larger addresses (e.g. TORv3) and encoded smaller ones as 16-byte IPv6 addresses. Change its type to `prevector`, so that it can hold larger addresses and do not disguise non-IPv6 addresses as IPv6. So the IPv4 address `1.2.3.4` is now encoded as `01020304` instead of `00000000000000000000FFFF01020304`. Rename `CNetAddr::ip` to `CNetAddr::m_addr` because it is not an "IP" or "IP address" (TOR addresses are not IP addresses). In order to preserve backward compatibility with serialization (where e.g. `1.2.3.4` is serialized as `00000000000000000000FFFF01020304`) introduce `CNetAddr` dedicated legacy serialize/unserialize methods. Adjust `CSubNet` accordingly. Still use `CSubNet::netmask[]` of fixed 16 bytes, but use the first 4 for IPv4 (not the last 4). Only allow subnetting for IPv4 and IPv6. ``` Completes backport (2/2) of core [[bitcoin/bitcoin#19628 | PR19628]]: bitcoin/bitcoin@102867c Depends on D9175. Test Plan: ninja all check-all ninja bitcoin-fuzzers Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D9176

Merge bitcoin#19628, bitcoin#19687: change CNetAddr::ip to have flexible size

…esses from pre-0.2.9 nodes 7b6d0f1 Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (Raúl Martínez (RME)) Pull request description: The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before. This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot). Credits for discovering this go to sipa in bitcoin#19628 (comment) Thanks for the attention! ACKs for top commit: sipa: utACK 7b6d0f1 vasild: ACK 7b6d0f1 Tree-SHA512: c5fab59dda2acafe143f607a4c5b636a54ac76fba651cad1ad1b09c94e88ab39503a31c2244c8f2664da68456c2a870c601d8894139c55cde9ece8161913ed2e

ecde04a [Consensus] Bump Active Protocol version to 70923 for v5.3 (random-zebra) b63e4f5 Consensus: Add v5.3 enforcement height for testnet. (furszy) f44be94 Only relay IPv4, IPv6, Tor addresses (Pieter Wuille) 015298c fix: tor: Call event_base_loopbreak from the event's callback (furszy) 34ff7a8 Consensus: Add mnb ADDRv2 guard. (furszy) b4515dc GUI: Present v3 onion addresses properly in MNs list. (furszy) 337d43d tests: don't export in6addr_loopback (Vasil Dimov) 2cde8e0 GUI: Do not show the tor v3 onion address in the topbar. (furszy) 0b5f406 Doc: update tor.md with latest upstream information. (furszy) 89df7f2 addrman: ensure old versions don't parse peers.dat (Vasil Dimov) bb90c5c test: add getnetworkinfo network name regression tests (Jon Atack) d8e01b5 rpc: update GetNetworksInfo() to not return unsupported networks (Jon Atack) 57fc7b0 net: update GetNetworkName() with all enum Network cases (Jon Atack) 647d60b tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong) d4d6729 Allow running rpc_bind.py --nonloopback test without IPv6 (Kristaps Kaupe) 4a034d8 test: Add rpc_bind test to default-run tests (Wladimir J. van der Laan) 61a08af [tests] bind functional test nodes to 127.0.0.1 Prevents OSX firewall (Sjors Provoost) 6a4f1e0 test: Add basic addr relay test (furszy) 78aa61c net: Make addr relay mockable (furszy) ba954ca Send and require SENDADDRV2 before VERACK (Pieter Wuille) 61c2ed4 Bump net protocol version + don't send 'sendaddrv2' to pre-70923 software (furszy) ccd508a tor: make a TORv3 hidden service instead of TORv2 (Vasil Dimov) 6da9a14 net: advertise support for ADDRv2 via new message (furszy) e58d5d0 Migrate to test_large_inv() to Misbehaving logging. (furszy) d496b64 [QA] fix mininode CAddress ser/deser (Jonas Schnelli) cec9567 net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). (furszy) b8c1dda streams update: get rid of nType and nVersion. (furszy) 3eaa273 Support bypassing range check in ReadCompactSize (Pieter Wuille) a237ba4 net: recognize TORv3/I2P/CJDNS networks (Vasil Dimov) 8e50853 util: make EncodeBase32 consume Spans (Sebastian Falbesoner) 1f67e30 net: CNetAddr: add support to (un)serialize as ADDRv2 (Vasil Dimov) 2455420 test: move HasReason so it can be reused (furszy) d41adb4 util: move HasPrefix() so it can be reused (Vasil Dimov) f6f86af Unroll Keccak-f implementation (Pieter Wuille) 45222e6 Implement keccak-f[1600] and SHA3-256 (Pieter Wuille) 08ad06d net: change CNetAddr::ip to have flexible size (furszy) 3337219 net: improve encapsulation of CNetAddr. (furszy) 910d5c4 test: Do not instantiate CAddrDB for static call (Hennadii Stepanov) 6b607ef Drop IsLimited in favor of IsReachable (Ben Woosley) a40711b IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf) 8839828 net: don't accept non-left-contiguous netmasks (Vasil Dimov) 5d7f864 rpcbind: Warn about exposing RPC to untrusted networks (Luke Dashjr) 2a6abd8 CNetAddr: Add IsBindAny method to check for INADDR_ANY (Luke Dashjr) 4fdfa45 net: Always default rpcbind to localhost, never "all interfaces" (Luke Dashjr) 31064a8 net: Minor accumulated cleanups (furszy) 9f9c871 tests: Avoid using C-style NUL-terminated strings as arguments (practicalswift) f6c52a3 tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters (practicalswift) a751b9b net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface (furszy) f30869d test: add IsRFC2544 tests (Mark Tyneway) ed5abe1 Net: Proper CService deserialization + GetIn6Addr return false if addr isn't an IPv6 addr (furszy) 86d73fb net: save the network type explicitly in CNetAddr (Vasil Dimov) ad57dfc net: document `enum Network` (Vasil Dimov) cb160de netaddress: Update CNetAddr for ORCHIDv2 (Carl Dong) c3c04e4 net: Better misbehaving logging (furszy) 3660487 net: Use C++11 member initialization in protocol (Marco) 082baa3 refactor: Drop unused CBufferedFile::Seek() (Hennadii Stepanov) e2d776a util: CBufferedFile fixes (Larry Ruane) 6921f42 streams: backport OverrideStream class (furszy) Pull request description: Conjunction of a large number of back ports, updates and refactorings that made with the final goal of implementing v3 Onion addresses support (BIP155 https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) before the tor v2 addresses EOL, scheduled, by the Tor project, for (1) July 15th: v2 addr support removal from the code base, and (2) October 15th: v2 addr network disable, where **every peer in our network running under Tor will loose the connection and drop the network**. As BIP155 describes, this is introducing a new P2P message to gossip longer node addresses over the P2P network. This is required to support new-generation Onion addresses, I2P, and potentially other networks that have longer endpoint addresses than fit in the 128 bits of the current addr message. In order to achieve the end goal, had to: 1. Create Span class and push it up to latest Bitcoin implementation. 2. Update the whole serialization framework and every object using it up to latest Bitcoin implementation (3-4 years ahead of what we currently are in master). 3. Update the address manager implementing ASN-based bucketing of the network nodes. 4. Update and refactor the netAddress and address manager tests to latest Bitcoin implementation (4 years ahead of what we currently are in master). 5. Several util string, vector, encodings, parsing, hashing backports and more.. Important note: This PR it is not meant to be merged as a standalone PR, will decouple smaller ones moving on. Adding on each sub-PR its own description isolated from this big monster. Second note: This is still a **work-in-progress**, not ready for testing yet. I'm probably missing to mention few PRs that have already adapted to our sources. Just making it public so can decouple the changes, we can start merging them and i can continue working a bit more confortable (rebase a +170 commits separate branch is not fun..). ### List of back ported and adapted PRs: Span and Serialization: ---------------- * bitcoin#12886. * bitcoin#12916. * bitcoin#13558. * bitcoin#13697. (Only Span's commit 29943a9) * bitcoin#17850. * bitcoin#17896. * bitcoin#12752. * bitcoin#16577. * bitcoin#16670. (without faebf62) * bitcoin#17957. * bitcoin#18021. * bitcoin#18087. * bitcoin#18112 (only from 353f376 that we don't support). * bitcoin#18167. * bitcoin#18317. * bitcoin#18591 (only Span's commit 0fbde48) * bitcoin#18468. * bitcoin#19020. * bitcoin#19032. * bitcoin#19367. * bitcoin#19387. Net, NetAddress and AddrMan: ---------------- * bitcoin#7932. * bitcoin#10756. * bitcoin#10765. * bitcoin#12218. * bitcoin#12855. * bitcoin#13532. * bitcoin#13575. * bitcoin#13815. * bitcoin#14532. * bitcoin#15051. * bitcoin#15138. * bitcoin#15689. * bitcoin#16702. * bitcoin#17243. * bitcoin#17345. * bitcoin#17754. * bitcoin#17758. * bitcoin#17812. * bitcoin#18023. * bitcoin#18454. * bitcoin#18512. * bitcoin#19314. * bitcoin#19687 Keys and Addresses encoding: ---------------- * bitcoin#11372. * bitcoin#17511. * bitcoin#17721. Util: ---------------- * bitcoin#9140. * bitcoin#16577. * bitcoin#16889. * bitcoin#19593. Bench: ---------------- * bitcoin#16299. BIP155: ---------------- * bitcoin#19351. * bitcoin#19360. * bitcoin#19534. * bitcoin#19628. * bitcoin#19841. * bitcoin#19845. * bitcoin#19954. * bitcoin#19991 (pending). * bitcoin#19845. * bitcoin#20000 (pending). * bitcoin#20120. * bitcoin#20284. * bitcoin#20564. * bitcoin#21157 (pending). * bitcoin#21564 (pending). * Fully removed v2 onion addr support. * Add hardcoded seeds. * Add release-notes, changes to files.md and every needed documentation. I'm currently working on the PRs marked as "pending", this isn't over, but I'm pretty pretty close :). What a long road.. ACKs for top commit: random-zebra: utACK ecde04a Fuzzbawls: ACK ecde04a Tree-SHA512: 82c95fbda76fce63f96d8a9af7fa9a89cb1e1b302b7891e27118a6103af0be23606bf202c7332fa61908205e6b6351764e2ec23d753f1e2484028f57c2e8b51a

…tion 886be97 Ignore incorrectly-serialized banlist.dat entries (Pieter Wuille) 883cea7 Restore compatibility with old CSubNet serialization (Pieter Wuille) Pull request description: bitcoin#19628 changed CSubNet for IPv4 netmasks, using the first 4 bytes of `netmask` rather than the last 4 to store the actual mask. Unfortunately, CSubNet objects are serialized on disk in banlist.dat, breaking compatibility with existing banlists (and bringing them into an inconsistent state where entries reported in `listbanned` cannot be removed). Fix this by reverting to the old format (just for serialization). Also add a sanity check to the deserializer so that nonsensical banlist.dat entries are ignored (which would otherwise be possible if someone added IPv4 entries after bitcoin#19628 but without this PR). Reported by Greg Maxwell. ACKs for top commit: laanwj: Code review ACK 886be97 vasild: ACK 886be97 Tree-SHA512: d3fb91e8ecd933406e527187974f22770374ee2e12a233e7870363f52ecda471fb0b7bae72420e8ff6b6b1594e3037a5115984c023dbadf38f86aeaffcd681e7

Backport of bitcoin/bitcoin#19628 to our codebase. TODO: - Deprecate CSubNet::CSubNet(const std::string &strSubnet, bool fAllowLookup) ctor and use ctor's from bitcoin instead: CSubNet(); CSubNet(const CNetAddr& addr, uint8_t mask); CSubNet(const CNetAddr& addr, const CNetAddr& mask); //constructor for single ip subnet (<ipv4>/32 or <ipv6>/128) explicit CSubNet(const CNetAddr& addr); - Refactor CService, unsigned short portIn -> uint16_t portIn - Add additional net_subnet unit tests (mandatory!) - Do not accept invalid netmasks that have 0-bits followed by 1-bits and only allow subnetting for IPv4 and IPv6.

vasild mentioned this pull request Jul 30, 2020

Implement ADDRv2 support (part of BIP155) #19031

Closed

11 tasks

vasild mentioned this pull request Jul 30, 2020

net: save the network type explicitly in CNetAddr #19534

Merged

laanwj added the P2P label Jul 30, 2020

This was referenced Jul 30, 2020

net: Make DNS lookup mockable, add fuzzing harness #19415

Merged

addrman: improve performance by using more suitable containers #18722

Merged

Simplify hash.h interface using Spans #19326

Merged

practicalswift reviewed Aug 1, 2020

View reviewed changes

src/netaddress.h Outdated Show resolved Hide resolved

DrahtBot mentioned this pull request Aug 2, 2020

Add -netinfo peer connections dashboard #19643

Merged

sipa reviewed Aug 3, 2020

View reviewed changes

src/netaddress.cpp Outdated Show resolved Hide resolved

src/netaddress.cpp Outdated Show resolved Hide resolved

src/netaddress.cpp Outdated Show resolved Hide resolved

src/netaddress.h Outdated Show resolved Hide resolved

DrahtBot added the Needs rebase label Aug 3, 2020

vasild force-pushed the make_CNetAddr_ip_flexible branch from daa1d8b to 67ccd99 Compare August 5, 2020 11:01

vasild force-pushed the make_CNetAddr_ip_flexible branch from 67ccd99 to 11632c7 Compare August 5, 2020 11:30

DrahtBot removed the Needs rebase label Aug 5, 2020

laanwj reviewed Aug 7, 2020

View reviewed changes

src/test/fuzz/asmap.cpp Outdated Show resolved Hide resolved

laanwj reviewed Aug 7, 2020

View reviewed changes

src/netaddress.cpp Show resolved Hide resolved

laanwj reviewed Aug 7, 2020

View reviewed changes

src/netaddress.cpp Outdated Show resolved Hide resolved

vasild force-pushed the make_CNetAddr_ip_flexible branch from 11632c7 to 1987730 Compare August 7, 2020 20:39

DrahtBot mentioned this pull request Aug 8, 2020

refactor: make EncodeBase{32,64} consume Spans #19687

Merged

vasild force-pushed the make_CNetAddr_ip_flexible branch from 1987730 to d0e2e38 Compare August 10, 2020 13:09

vasild force-pushed the make_CNetAddr_ip_flexible branch from d0e2e38 to b710205 Compare August 10, 2020 20:18

vasild force-pushed the make_CNetAddr_ip_flexible branch from b710205 to bfe7d1b Compare August 11, 2020 12:05

jonatack reviewed Aug 12, 2020

View reviewed changes

src/netaddress.h Outdated Show resolved Hide resolved

src/netaddress.h Outdated Show resolved Hide resolved

src/netaddress.cpp Outdated Show resolved Hide resolved

src/netaddress.cpp Outdated Show resolved Hide resolved

kwvg mentioned this pull request Mar 8, 2021

partial #8149 and merge #19845, #19954: Complete the BIP155 implementation and upgrade to TORv3 dashpay/dash#4025

Closed

kwvg pushed a commit to kwvg/dash that referenced this pull request May 20, 2021

Merge bitcoin#19628: change CNetAddr::ip to have flexible size

3fe52df

kwvg added a commit to kwvg/dash that referenced this pull request May 20, 2021

Patch bitcoin#19628: Modify original PR to fix compile errors

47906dc

kwvg added a commit to kwvg/dash that referenced this pull request May 20, 2021

Merge bitcoin#19628: change CNetAddr::ip to have flexible size

8752621

kwvg added a commit to kwvg/dash that referenced this pull request May 20, 2021

Patch bitcoin#19628: Modify original PR to fix compile errors

1245d45

kwvg mentioned this pull request May 20, 2021

Merge #19628, #19687: change CNetAddr::ip to have flexible size dashpay/dash#4166

Merged

kwvg added a commit to kwvg/dash that referenced this pull request May 21, 2021

Merge bitcoin#19628: change CNetAddr::ip to have flexible size

e84a603

kwvg added a commit to kwvg/dash that referenced this pull request May 21, 2021

Patch bitcoin#19628: Modify original PR to fix compile errors

5aadf43

kwvg added a commit to kwvg/dash that referenced this pull request May 22, 2021

Patch bitcoin#19628: Modify original PR to fix compile errors

69b6d6a

kwvg added a commit to kwvg/dash that referenced this pull request May 23, 2021

Merge bitcoin#19628: change CNetAddr::ip to have flexible size

337c15a

PastaPastaPasta added a commit to dashpay/dash that referenced this pull request May 23, 2021

Merge pull request #4166 from kittywhiskers/encodespan

41a8349

Merge bitcoin#19628, bitcoin#19687: change CNetAddr::ip to have flexible size

furszy mentioned this pull request Jun 7, 2021

Road to Tor v3 support (BIP155) PIVX-Project/PIVX#2411

Merged

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: change CNetAddr::ip to have flexible size #19628

net: change CNetAddr::ip to have flexible size #19628

vasild commented Jul 30, 2020 •

edited by maflcko

Loading

jonatack commented Jul 30, 2020

vasild commented Jul 30, 2020

DrahtBot commented Jul 30, 2020 •

edited

Loading

vasild commented Aug 5, 2020

vasild commented Aug 5, 2020

vasild commented Aug 10, 2020

vasild commented Aug 10, 2020

vasild commented Aug 11, 2020

jonatack left a comment

net: change CNetAddr::ip to have flexible size #19628

net: change CNetAddr::ip to have flexible size #19628

Conversation

vasild commented Jul 30, 2020 • edited by maflcko Loading

jonatack commented Jul 30, 2020

vasild commented Jul 30, 2020

DrahtBot commented Jul 30, 2020 • edited Loading

Conflicts

vasild commented Aug 5, 2020

vasild commented Aug 5, 2020

vasild commented Aug 10, 2020

vasild commented Aug 10, 2020

vasild commented Aug 11, 2020

jonatack left a comment

Choose a reason for hiding this comment

vasild commented Jul 30, 2020 •

edited by maflcko

Loading

DrahtBot commented Jul 30, 2020 •

edited

Loading