Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macdeployqtplus can't delpoy Qt 4.6 Frameworks #2015

Closed
themighty1 opened this issue Nov 15, 2012 · 2 comments
Closed

macdeployqtplus can't delpoy Qt 4.6 Frameworks #2015

themighty1 opened this issue Nov 15, 2012 · 2 comments

Comments

@themighty1
Copy link

I'm on OSX 10.5 with qt-mac-opensource-4.6.0.dmg from nokia's site. Qt Frameworks are in /Library/Frameworks
The strange thing is that the linker doesn't write the full path to the Qt Frameworks into the executable, like so:

otool -L ./Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
......
QtGui.framework/Versions/4/QtGui (compatibility version 4.6.0, current version 4.6.0)
QtCore.framework/Versions/4/QtCore (compatibility version 4.6.0, current version 4.6.0)
......

Note that there is no / in front of QtGui and QtCore.
macdeployqtplus apparently can't parse such a line and fails to deploy.

My suggestion would be to modify macdeployqtplus so that when encountering a path which starts with no "/" but with Qt*, macdeployqtplus prepends /Library/Frameworks.
Also macdeployqtplus can't find the plugins directory which by default is in /Developer/Applications/Qt/Plugins
@gavinandresen
Copy link
Contributor

Patches welcome: I don't have an OSX 10.5 machine to test a fix, but I can make sure that a fix that works on 10.5 doesn't break deployment using 10.6.

@themighty1 themighty1 mentioned this issue Nov 21, 2012
Merged
@laanwj
Copy link
Member

laanwj commented Nov 11, 2013

A patch for this was merged, so I assume this was solved. Closing.

@laanwj laanwj closed this as completed Nov 11, 2013
KolbyML pushed a commit to KolbyML/bitcoin that referenced this issue Dec 5, 2020
@random-zebra
Merge bitcoin#2015: [Net] Prevent un-necessary disconnections in vers…
860064b 
…ion handshake

9aae20b [Net] Prevent un-necessary disconnections in version handshake (Fuzzbawls)

Pull request description:

  Discard known stale protocol enforcement spork data during startup.

  Quick workaround for clients that have not yet seen the new spork 15 broadcast since they last ran.

  This evaluates the signing time of spork 15 (used to disconnect peers in the version handshake) and
  discards the data of known-stale information. This will prevent the need for such clients to manually
  delete the `sporks` folder in their datadir.

ACKs for top commit:
  furszy:
    looking good now, utACK 9aae20b
  random-zebra:
    utACK 9aae20b

Tree-SHA512: d132abb6ad414624930e19deb3dab7b41068d635582821166f43f257342d935676a72845ec2fb63a439ef847b65ecbce4f7218f60efd093716dd858164b046f2
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laanwj @gavinandresen @themighty1