Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why don't we have more checkpoints? #21886

Closed
abhiShandy opened this issue May 9, 2021 · 7 comments
Closed

Why don't we have more checkpoints? #21886

abhiShandy opened this issue May 9, 2021 · 7 comments

Comments

@abhiShandy
Copy link

abhiShandy commented May 9, 2021

Is your feature request related to a problem? Please describe.

src/chainparams.cpp:146 has few checkpoints for the mainnet using a table of block and blockhash. Why does it end at block 295000?

Describe the solution you'd like

Either add a comment with an explanation for given number checkpoints or add checkpoints at an agreed block interval.

Describe alternatives you've considered

Additional context

Screen Shot 2021-05-09 at 8 58 49 AM

@brunoerg
Copy link
Contributor

See this answer on bitcoin stackexchange.

I think they are not so useful and if we need to use them, it means the system is already broken.

@kristapsk
Copy link
Contributor

It is not uncommon for people to add additional checkpoints to their nodes. For example, Bitcoin Knots, which is patched version of Bitcoin Core by @luke-jr, adds additional checkpoints.

@maflcko
Copy link
Member

maflcko commented May 20, 2021

Could make sense to mention briefly in the code what https://bitcoin.stackexchange.com/a/70824/3576 says?

@brunoerg
Copy link
Contributor

I think so, @MarcoFalke.

@abhiShandy
Copy link
Author

@brunoerg Shall I remove the checkpoints (and the validation code) to avoid the confusion?

@sipa
Copy link
Member

sipa commented May 20, 2021

@abhiShandy No, they're still needed to prevent low-difficulty header spam. It's not a particularly strong attack, but without checkpoints it's trivial. The current checkpoints suffice to make it sufficiently expensive.

@adamjonas
Copy link
Member

Closing since the questions seems to be answered sufficiently.

Checkpoints are currently required, but see #25725 for a glimpse into the future.

@bitcoin bitcoin locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants
@sipa @adamjonas @fanquake @kristapsk @maflcko @abhiShandy @brunoerg and others