-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable clang-tidy bugprone-argument-comment and fix violations #22903
Conversation
To test on Ubuntu:
|
Is it possibly instead of:
? (https://github.com/rizsotto/Bear#how-to-use) edit: I think there are two more instances where the parameter names are not entirely correct: |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
No, that doesn't work for me:
|
My bear version is |
@kiminuo Thanks, updated comment |
fa91f31
to
fa57fa1
Compare
Thanks, fixed |
Concept ACK Could add this specific |
Seems like something that should be done in a separate pull request to keep the discussion here focussed on adding the flag and fixing the violations. |
cr ACK fa57fa1
Makes sense! I'd gladly review such PR FWIW :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa57fa1
Named arguments can be dangerous when they are wrong, because they are not enforced by the compiler. Currently there are only minor typos, no actual bugs.
Fix the typos and add the
.clang-tidy
file to make it easier to find them in the future.