Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Add ancestor{count,size,fees} to listunspent output #12677

Open
wants to merge 4 commits into
base: master
from

Conversation

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Mar 12, 2018

Requested by a user

Copy link
Member

@promag promag left a comment

Could add tests for new fields. Also, help message could state when these are in the response.

src/wallet/rpcwallet.cpp Outdated Show resolved Hide resolved
@BitcoinGeek
Copy link

@BitcoinGeek BitcoinGeek commented Mar 13, 2018

Thank you Luke for taking it into consideration and adding it !

@meshcollider
Copy link
Member

@meshcollider meshcollider commented Mar 13, 2018

Concept ACK, perhaps it'd be cleaner to sub-object them like you put in the title of the PR

@sipa
Copy link
Member

@sipa sipa commented Mar 17, 2018

Concept ACK

@luke-jr luke-jr force-pushed the luke-jr:listunspent_ancestorinfo branch to daeb431 Mar 31, 2018
@promag
Copy link
Member

@promag promag commented May 3, 2018

@luke-jr is this still relevant? There are a couple of suggestions above and it's missing test(s) update.

@achow101
Copy link
Member

@achow101 achow101 commented Jul 9, 2018

utACK daeb431

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jul 10, 2018

@promag Indeed, needs a trivial test where they are all different from 0

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Oct 20, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Feb 12, 2019

Rebased and added tests

@luke-jr luke-jr force-pushed the luke-jr:listunspent_ancestorinfo branch from c401d85 to 18922f8 Feb 12, 2019
@DrahtBot DrahtBot added Needs rebase and removed Needs rebase labels Feb 12, 2019
@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Apr 6, 2019

Rebased again

@luke-jr luke-jr force-pushed the luke-jr:listunspent_ancestorinfo branch from 18922f8 to 305ab80 Apr 6, 2019
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Sep 30, 2019

There hasn't been much activity lately and the patch still needs rebase, so I am closing this for now. Please let me know when you want to continue working on this, so the pull request can be re-opened.
@sipa
Copy link
Member

@sipa sipa commented Oct 18, 2019

Concept ACK

@DrahtBot DrahtBot mentioned this pull request Jun 29, 2020
1 of 2 tasks complete
src/wallet/rpcwallet.cpp Outdated Show resolved Hide resolved
Copy link
Member

@promag promag left a comment

Code review ACK, could remove unnecessary include and follow @instagibbs suggestion too. Also tag needs release note.

src/wallet/rpcwallet.cpp Outdated Show resolved Hide resolved
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jul 20, 2020

@luke-jr Are you still working on this?

@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Aug 9, 2020

Naming request: in the code and the RPC output, could ancestorsize, ancestorfees, and ancestorcount be snakecased?

@jonatack No, we already have these names in the RPC interface as-is (see MempoolEntryDescription).

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Aug 11, 2020

Should be good to go in after another rebase

@JeremyRubin
Copy link
Contributor

@JeremyRubin JeremyRubin commented Aug 11, 2020

To be annoying -- slight concept nack without more info.

  1. The field should be named mempool_ancestors, as there is a distinct concept of the ancestry of a coin (e.g., max distance to a coinbase txn).
  2. If the desired thing to know is if a transaction can support more descendants, we should return the field as n_descendants_placeable_in_mempool or something. The ancestor stats themselves are insufficient to figure this out.
  3. We can compute 2 against both our own local settings and against the network defaults...

Without a concrete user story in mind, it's hard to see how this information helps a user complete a task. For what purpose would a user use this? @BitcoinGeek

@luke-jr luke-jr force-pushed the luke-jr:listunspent_ancestorinfo branch from db9baad to 0db275f Aug 20, 2020
@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Aug 20, 2020

Rebased

@luke-jr luke-jr force-pushed the luke-jr:listunspent_ancestorinfo branch from 0db275f to e9464b6 Oct 30, 2020
@DrahtBot DrahtBot removed the Needs rebase label Oct 30, 2020
Copy link
Contributor

@kristapsk kristapsk left a comment

ACK 0db275f. Looked at code, did automated tests and also manually tested on a testnet.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Dec 1, 2020

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.