Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.x] Second round signapple backports (M1) #24514

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Mar 9, 2022

This backports additional signapple and macOS codesigning changes from #24506 for 23.x (skipping #24503, which is an interim signapple update, and the certvalidator change, which is not strictly necessary), and should complete the changes required to perform M1 codesigning for the 23.x release.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1fd91da, I have reviewed the code and it looks OK, I agree it can be merged.

@fanquake
Copy link
Member Author

Guix Build:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
4b348caec13847b508d9d6366a93c04fdd51972bd01c92bbf93b1b9e37523575  guix-build-1fd91da45438/output/aarch64-linux-gnu/SHA256SUMS.part
cd1dcc416a71dcb5488434c6a53f81ba609bb1c8e63336564ee364475119495b  guix-build-1fd91da45438/output/aarch64-linux-gnu/bitcoin-1fd91da45438-aarch64-linux-gnu-debug.tar.gz
39eea798a13892994bd272b92af8bb8658cc2c2af94402bf285eb8cb50185121  guix-build-1fd91da45438/output/aarch64-linux-gnu/bitcoin-1fd91da45438-aarch64-linux-gnu.tar.gz
f941bcda7ca31717385697ec66cf2c8aa35721b303e354654f73cab49bf39b71  guix-build-1fd91da45438/output/arm-linux-gnueabihf/SHA256SUMS.part
717e7c865fd2b35d0565022d8dd1c3f6108a4023ef1e4f40070708d2a3df5c5c  guix-build-1fd91da45438/output/arm-linux-gnueabihf/bitcoin-1fd91da45438-arm-linux-gnueabihf-debug.tar.gz
67329b20b5c97f81db30cf52ad90edb290bee4fefc7897b47cb23669876b108b  guix-build-1fd91da45438/output/arm-linux-gnueabihf/bitcoin-1fd91da45438-arm-linux-gnueabihf.tar.gz
2dba20a3c0bd0e6f2f1c31d305652b3968ac33ceed6c2fedb60e0e6776342ca8  guix-build-1fd91da45438/output/arm64-apple-darwin/SHA256SUMS.part
ed30d1884210f18b51030be8e4794aa874bfb3009c3e91ad0bf302fee3b189d1  guix-build-1fd91da45438/output/arm64-apple-darwin/bitcoin-1fd91da45438-arm64-apple-darwin.tar.gz
62a5a8d042756a88d7211f914dd95e81398962e4afc765394556c42a44307127  guix-build-1fd91da45438/output/arm64-apple-darwin/bitcoin-1fd91da45438-osx-unsigned.dmg
ee9fd7ebcc8a885d55ec6fe21c4aecce7e8a932941e676d93321600f9ebc8017  guix-build-1fd91da45438/output/arm64-apple-darwin/bitcoin-1fd91da45438-osx-unsigned.tar.gz
5f6d61323caf4bc079b6f2ea366c65bc40dce7e27258f936670574ac8c966694  guix-build-1fd91da45438/output/dist-archive/bitcoin-1fd91da45438.tar.gz
f478908d28beb5b3481919b689a7cc933f2fac7f4a21ef425f37c840256e0cf4  guix-build-1fd91da45438/output/powerpc64-linux-gnu/SHA256SUMS.part
6b25fb26102a98ecbcb74c6db8b02573e29991f0ac26bb0f7a8aede7a1111bc5  guix-build-1fd91da45438/output/powerpc64-linux-gnu/bitcoin-1fd91da45438-powerpc64-linux-gnu-debug.tar.gz
3eab08cde5a5940e7a1fa9dd4d2eedb06421da677dba69a340e616fcb80ea567  guix-build-1fd91da45438/output/powerpc64-linux-gnu/bitcoin-1fd91da45438-powerpc64-linux-gnu.tar.gz
ac2672a4b9c3d1a6ecd61a5885c5633e7987d7f54d1171896a13d19ba90524c7  guix-build-1fd91da45438/output/powerpc64le-linux-gnu/SHA256SUMS.part
10e6e1723a829649cd87a8cb1c3e1f3b5ad708bf72948ee4e34b7452f596efdd  guix-build-1fd91da45438/output/powerpc64le-linux-gnu/bitcoin-1fd91da45438-powerpc64le-linux-gnu-debug.tar.gz
dcfb24e86f8c90d1027035912011b45136e9c62fd4d32f2a16b44f7707d1fc71  guix-build-1fd91da45438/output/powerpc64le-linux-gnu/bitcoin-1fd91da45438-powerpc64le-linux-gnu.tar.gz
a66e0935f2c718808492c81fe10c8dbdf5db99f40242d70d69eb17c0dea08b58  guix-build-1fd91da45438/output/riscv64-linux-gnu/SHA256SUMS.part
08698b92c99497df432e2c7a520fb311a9e5292eb82a57229b2a37f4b610807f  guix-build-1fd91da45438/output/riscv64-linux-gnu/bitcoin-1fd91da45438-riscv64-linux-gnu-debug.tar.gz
30b5487966665556ac01eb813bc40dcf9bf803ca58171f648bd360f2ec5018bb  guix-build-1fd91da45438/output/riscv64-linux-gnu/bitcoin-1fd91da45438-riscv64-linux-gnu.tar.gz
e565bd976a01acb0010f78e4e01d6f6ea30e0919d2d133059cd0c3ec7c054de3  guix-build-1fd91da45438/output/x86_64-apple-darwin/SHA256SUMS.part
56777929e73b454aeb56cf8006174c1ed6afa62e905c009acdd78f2439603621  guix-build-1fd91da45438/output/x86_64-apple-darwin/bitcoin-1fd91da45438-osx-unsigned.dmg
9b7d375049e2422380a21c92aac2a3c7c46768e1b88f202b7599f215feb184f2  guix-build-1fd91da45438/output/x86_64-apple-darwin/bitcoin-1fd91da45438-osx-unsigned.tar.gz
69a2a6889967456eca1a17907df73b8a8cb5ee70e9938267dc47f20ac291258d  guix-build-1fd91da45438/output/x86_64-apple-darwin/bitcoin-1fd91da45438-osx64.tar.gz
7eb67eb1913ce38ab0b90399774234b7f2717f4bbc7f6ee861b673d364d1f979  guix-build-1fd91da45438/output/x86_64-linux-gnu/SHA256SUMS.part
142219da385a0ea5400e7765d29db0b915540be141f14fe5737ba75bc58c7858  guix-build-1fd91da45438/output/x86_64-linux-gnu/bitcoin-1fd91da45438-x86_64-linux-gnu-debug.tar.gz
f333ea0918a064c53621389359778471c7b79ae201cc8fbf015af0f86c4650ae  guix-build-1fd91da45438/output/x86_64-linux-gnu/bitcoin-1fd91da45438-x86_64-linux-gnu.tar.gz
fa43046277d9ff55133d4db6d25005a94a3256b7d7c04691d5a34e7c50d574a1  guix-build-1fd91da45438/output/x86_64-w64-mingw32/SHA256SUMS.part
78672ec2e10eedf69e4c102cd83f9a13adc388e57a48855bea900db0e0a8db5e  guix-build-1fd91da45438/output/x86_64-w64-mingw32/bitcoin-1fd91da45438-win-unsigned.tar.gz
97ffa1266084dfb696d7a27802f371fb7ab168f2e56b055b5680f49adb7cf053  guix-build-1fd91da45438/output/x86_64-w64-mingw32/bitcoin-1fd91da45438-win64-debug.zip
df9e10528a92193df677286238c0255e5b7dfb8024dcadef6efcb6534c76f2b6  guix-build-1fd91da45438/output/x86_64-w64-mingw32/bitcoin-1fd91da45438-win64-setup-unsigned.exe
31c73cf9b4e56a2b2a2c3a457e76e5694ae842ffb936ad5f86fc140661cd3403  guix-build-1fd91da45438/output/x86_64-w64-mingw32/bitcoin-1fd91da45438-win64.zip

@fanquake fanquake merged commit 2bd5fdb into bitcoin:23.x Mar 10, 2022
@fanquake fanquake deleted the second_round_signapple_backports branch March 10, 2022 09:48
@bitcoin bitcoin locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants