Add pool based memory resource #25325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinus
force-pushed
the
2022-06-very-not-scary-NodePoolResource
branch
2 times, most recently
from
6de57f7
to
d3c437f
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
This was referenced Jun 10, 2022
martinus
force-pushed
the
2022-06-very-not-scary-NodePoolResource
branch
3 times, most recently
from
850fe38
to
ba38016
Compare
Riahiamirreza
approved these changes
Jun 11, 2022
martinus
force-pushed
the
2022-06-very-not-scary-NodePoolResource
branch
5 times, most recently
from
6932541
to
b56c223
Compare
9 tasks
martinus
force-pushed
the
2022-06-very-not-scary-NodePoolResource
branch
4 times, most recently
from
98bb268
to
d196da1
Compare
martinus
changed the title
martinus
force-pushed
the
2022-06-very-not-scary-NodePoolResource
branch
from
d196da1
to
9205b60
Compare
|
rebased to 9205b60 with minor fixes in |
DrahtBot
requested review from
jonatack,
LarryRuane and
sipa
and removed request for
LarryRuane
jonatack
approved these changes
Mar 24, 2023
|
ACK 9f947fc |
martinus
added a commit
to martinus/map_benchmark
that referenced
this pull request
Apr 4, 2023
|
re-ACK 9f947fc |
|
Posthumous utACK 9f947fc |
|
Wohoo 🎉 Thanks everyone for making this happen! |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 21, 2023
1 task
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A memory resource similar to
std::pmr::unsynchronized_pool_resource, but optimized for node-based containers. The goal is to be able to cache more coins with the same memory usage, and allocate/deallocate faster.This is a reimplementation of #22702. The goal was to implement it in a way that is simpler to review & test
There is now a generic
PoolResourcefor allocating/deallocating memory. This has practically the same API asstd::pmr::memory_resource. (Unfortunately I cannot use std::pmr because libc++ simply doesn't implement that API).Thanks to sipa there is now a fuzzer for PoolResource! On a fast machine I ran it for ~770 million executions without finding any issue.
The estimation of the correct node size is now gone, PoolResource now has multiple pools and just needs to be created large enough to have space for the unordered_map nodes.
I ran benchmarks with #22702, mergebase, and this PR. Frequency locked Intel i7-8700, clang++ 13.0.1 to reindex up to block 690000.
The performance is practically identical with #22702, just 0.4% slower. It's ~21% faster than master:
Note that on cache drops mergebase's memory doesnt go so far down because it does not free the
CCoinsMapbucket array.