Some database/-related recovery improvements #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sipa
commented
Apr 23, 2013
sipa
commented
- After clean shutdown, delete the database/ subdir. This means upgrading/changing the BDB dir won't kill you anymore because of incompatible logs.
- In case opening the database environment fails, move database/ to database.$TIMESTAMP.bak, and try again.
- Do not advise the user to nuke his datadir anymore - there's no point in doing so (closes BDB failures still suggest user to delete everything #2488).
- Drop double opening of the environment (includes remove duplicate bitdb.Open() code from init #2333).
- remove code from step 7, which we already have in step 5 of init
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ccda03b57022369c4352d0f5a816cff9ace833e6 for binaries and test log. |
|
ACK |
|
Looks good and should make it for 0.8.2 IMHO. |
|
ACK code I'd say it needs testing on Windows, to make sure the looks-right-on-Unix code works there. Or maybe I'm just being paranoid. |
|
ACK. Compiles and works as advertised on OSX. |
sipa
added a commit
that referenced
this pull request
May 3, 2013
Some database/-related recovery improvements
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Some database/-related recovery improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.