Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests skip code paths for parallel_script_checks==false #26757

Open
hebasto opened this issue Dec 27, 2022 · 1 comment
Open

Unit tests skip code paths for parallel_script_checks==false #26757

hebasto opened this issue Dec 27, 2022 · 1 comment

Comments

@hebasto
Copy link
Member

hebasto commented Dec 27, 2022

The Chainstate::ConnectBlock() function is implemented in a way that different code paths are used during runtime depending on the parallel_script_checks flag's value.

OTOH, the current test suit implementation with the following lines:

constexpr int script_check_threads = 2;
StartScriptCheckWorkerThreads(script_check_threads);
sets the parallel_script_checks to true for all cases.

For example, the outcome of miner_tests is affected by the parallel_script_checks flag's value.

@kevkevinpal
Copy link
Contributor

So do we want to modify the unit test to run miner_tests with both parallel_script_checks with both true and false?

or are there any other alternatives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants