New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsafe reduce_output when new coins are added #28180
Comments
I don't think so. This is more an implementation issue rather than a missing doc or a missing restriction. The issue arises because the code (as is now) mixes two different concepts; it treats the change output and the reduce output (output from where the fees will be taken) as they would be the same, when they are not. It can easily be seen here. To untangle the two concepts, we need to fix #27601 first. It is the reason why we drop the change output from the recipients list instead of simply mark it as SFFO (which would be the easiest implementation for a "reduce output" mechanism). |
What is the status here? This is the only issue tagged 26.0 that doesn't have a pull request associated |
Status is "waiting for others" in #27601 since July 27th. Happy to receive feedback on my last message there (#27601 (review)). The reason why this happens is explained above #28180 (comment). if we manage to merge #27601 (in any form), we can fix this issue cleanly. Basically, the only remaining point to discuss there is whether to have the transaction creation process automatically detecting change outputs when they match the custom change address or not. |
b3db8c9 rpc: bumpfee, improve doc for 'reduce_output' arg (furszy) Pull request description: Fixes bitcoin#28180. Resulted from discussions with S3RK, achow101, and Murch. The current argument name and description are dangerous as it don't describe the case where the user selects the recipient output as the change address. This one could end up been increased by the inputs minus outputs remainder. Which, when `bumpfee` adds new inputs to the transaction, leads the process to send more coins to the recipient. Which is not what the user would expect from a 'reduce_output' param naming. ACKs for top commit: S3RK: ACK b3db8c9 achow101: ACK b3db8c9 murchandamus: ACK b3db8c9 Tree-SHA512: 91f607e2f5849041d7c099afdddae11af8bed5b1ac90c9d22921267f272e21b44e107d6968e037f05f958a61fe29e94e5fb44b224fb3606f197f83ec4ba3b1e7
Is there an existing issue for this?
Current behaviour
See inline discussion at #26467 (comment)
@whitslack:
Expected behaviour
Not sure.
Improving the docs is one option, but this behaviour seem quite counter intuitive.
My own suggestion:
Steps to reproduce
Haven't tried.
Relevant log output
No response
How did you obtain Bitcoin Core
Compiled from source
What version of Bitcoin Core are you using?
Master after #26467
Operating system and version
Any
Machine specifications
No response
The text was updated successfully, but these errors were encountered: