Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule out hybrid keys in output descriptors #28511

Closed
darosior opened this issue Sep 20, 2023 · 0 comments · Fixed by #28587
Closed

Rule out hybrid keys in output descriptors #28511

darosior opened this issue Sep 20, 2023 · 0 comments · Fixed by #28587

Comments

@darosior
Copy link
Member

@achow101 noted we don't reject them therefore they must be silently accepted. This is not part of the specs, we should remove them. Also cc @sipa.

I can take care of this.
@sipa sipa mentioned this issue Oct 4, 2023
Merged
Frank-GER pushed a commit to syscoin/syscoin that referenced this issue Oct 13, 2023
@achow101
Merge bitcoin#28587: descriptors: disallow hybrid public keys
9fc8e80 
c1e6c54 descriptors: disallow hybrid public keys (Pieter Wuille)

Pull request description:

  Fixes bitcoin#28511

  The descriptor documentation (`doc/descriptors.md`) and [BIP380](https://github.com/bitcoin/bips/blob/master/bip-0380.mediawiki) explicitly require that hex-encoded public keys start with 02 or 03 (compressed) or 04 (uncompressed). However, the current parsing/inference code permit 06 and 07 (hybrid) encoding as well. Fix this.

ACKs for top commit:
  darosior:
    ACK c1e6c54
  achow101:
    ACK c1e6c54

Tree-SHA512: 23b674fb420619b2536d12da10008bb87cf7bc0333ec59e618c0d02c3574b468cc71248475ece37f76658d743ef51e68566948e903bca79fda5f7d75416fea4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

descriptors: disallow hybrid public keys sipa/bitcoin
1 participant
@darosior